feat(cli)!: remove console and dev implementations, keep the migration notices - #6657
Open
u9g wants to merge 2 commits into
Open
feat(cli)!: remove console and dev implementations, keep the migration notices#6657u9g wants to merge 2 commits into
u9g wants to merge 2 commits into
Conversation
Both commands were deprecated in #6656 in favor of `lk agent console` / `lk agent dev`. This drops their implementations — the local audio console, frequency visualizer, text mode, key reader, console worker, and the dev worker wiring — and keeps the commands as migration notices that exit 1. They still accept the old flags so existing invocations land on the notice instead of a usage error. `sounddevice` was only needed by the local console, so it is dropped as a dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6656: now that
consoleanddevare deprecated, remove the code and keep the messages.What's gone
From the legacy rich CLI (
cli/_legacy.py, −1.4k lines) andcli/readchar.py:ConsoleAudioInput/ConsoleAudioOutput, the sounddevice streams, APM wiring, and device validation/listingFrequencyVisualizer), text mode (prompt,live_status, run-event rendering, turn-metric formatting)_ConsoleWorker,_run_console, and thedevcommand's worker wiringAgentsConsolesession-IO surface (acquire_io,console_mode, recording); what remains is the rich printer + logging handler thatconnectanddownload-filesstill usesounddevice, which nothing else neededlk agent console/lk agent devare unaffected — they drive the TCP console andstartpath incli/cli.py, which this doesn't touch.What's kept
consoleanddevremain registered and print the migration notice, then exit 1:They accept their old flags (
--text,--no-reload,--log-level, …) so invocations written against the previous CLI reach the notice instead of a usage error.console --help/dev --helpsay the same.Docs
Every
python myagent.py console|devin the repo now readslk agent console|dev myagent.py— root README, AGENTS.md, and the example/plugin READMEs.Verification
ruff check,scripts/check_types.py(only the pre-existing cv2/loguru/boto3 stub errors), andpytest --unit(1646 passed;test_async_mcpneeds the uninstalledmcpextra, unrelated).TestDevCommandLogLevelis replaced by coverage that both commands exit 1 without starting a worker.