deps: go get -u + migrate dockertest v3 -> v4 - #115
Merged
Conversation
Sweeps go get -u ./... and bumps dockertest to v4, the only direct dep that needed an explicit major version bump. Migrates the 4 testutils helpers in internal/bus/bustest/ to v4 (Pool/Resource are now interfaces; NewPool/Run/Retry take ctx; RunWithOptions replaced by builder; Purge replaced by ClosableResource.Close). Other direct deps with newer majors available: none. +incompatible deps: twitchtv/twirp v8.1.3 (upstream choice, no module-aware path published).
Passes res.Code/res.Error/res.ErrorDetails straight through instead of round-tripping through NewErrorf, which also resolves the Go 1.25 vet complaint about a non-constant format string. Plus the previous form silently dropped error details.
paulwe
force-pushed
the
deps/protocol-major-updates
branch
from
June 4, 2026 22:56
998b669 to
4bab403
Compare
boks1971
approved these changes
Jun 5, 2026
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| err = pool.Client.Ping() |
paulwe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/bus/bustest/{bustest,redis,nats,local}.go. v4 makesPool/Resourceinterfaces, threadscontext.ContextthroughNewPool/Run/Retry, replacesRunWithOptions(&RunOptions{...})with aRun(ctx, repo, WithTag(...), WithName(...), ...)builder, and replacespool.Purge(resource)withresource.Close(ctx).go get -u ./...sweep: otel 1.40/1.43 -> 1.44, grpc 1.80 -> 1.81.1,golang.org/x/*minor bumps,genproto/googleapis/rpcpseudo-version refresh.Audit notes
/vN+1for every/vN).+incompatibledeps stay put:twitchtv/twirp(no module-aware path published),docker/cliindirect (Docker's chosen versioning).Test plan
go build ./...go test -count=0 ./...(pre-existing breakage ininternal/test/*fixtures referencingversion.PsrpcVersion_0_5fails on main too)go test ./internal/bus/...against a real Docker daemon to exercise the v4 runtime path