Skip to content

Improve log messages around plugin loading - #1186

Merged
lukasIO merged 2 commits into
mainfrom
lukas/better-plugin-load-logs
Jun 26, 2026
Merged

Improve log messages around plugin loading#1186
lukasIO merged 2 commits into
mainfrom
lukas/better-plugin-load-logs

Conversation

@lukasIO

@lukasIO lukasIO commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Before you submit your PR

Make sure the following is true before submitting your PR:

  • I have read the contributing guidelines and validated that this PR will be accepted.
  • I have read and followed the principles regarding breaking changes, testing, and code quality.

PR description

Describe the changes in this PR. Explain what the PR is meant to solve and how to reproduce the issue in the first place.

Breaking changes

If this PR introduces breaking changes, list them here and document the rationale for introducing such a change.

MSRV

If the PR modifies the crate's MSRV (Minimum Supported Rust Version), document it here.

Testing

Ideally, unit test the code you add, but ensure you're not repeating existing test cases. Use as many already written scaffolding, utilities as possible; write your own, when needed. If external services, APIs, tokens are required (e.g., running an LK server instance), provide the necessary information. Make sure your tests perform useful, context-aware assertions and do not simply emulate "happy paths".

Async

We want the project to be runtime-agnostic, so please reuse what's already in livekit-runtime and feel free to add anything missing. It's ok to use Tokio directly, when writing unit tests, if necessary. When testing, do not use artificial delays for the state to "catch up"; instead, respect the event flow and subscribe properly using channels or other mechanisms.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Changeset

The following package versions will be affected by this PR:

Package Bump
livekit patch
livekit-ffi patch

@xianshijing-lk xianshijing-lk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you able to test it with agent SDK and verify it logs the proper errors ?

@lukasIO
lukasIO merged commit 2ac870f into main Jun 26, 2026
23 checks passed
@lukasIO
lukasIO deleted the lukas/better-plugin-load-logs branch June 26, 2026 11:26
@knope-bot knope-bot Bot mentioned this pull request Jun 26, 2026
xianshijing-lk pushed a commit that referenced this pull request Jun 30, 2026
> [!IMPORTANT]
> Merging this pull request will create these releases

# webrtc-sys 0.3.36 (2026-06-30)
## Features

### Add `MaintainFramerateAndResolution` to `DegradationPreference` enum
to align with WebRTC M144.

- `MAINTAIN_FRAMERATE_AND_RESOLUTION` is now the recommended value
(replaces deprecated `DISABLED`)
- `DISABLED` is deprecated but still supported for backwards
compatibility
- Both values map to the same behavior: maintain framerate and
resolution, dropping frames if needed

## Fixes

- Fix AV1 subscriber decode when packet trailers are enabled.
# libwebrtc 0.3.39 (2026-06-30)
## Features

### Improve initial video quality by setting `x-google-start-bitrate`
SDP hint for all video codecs (VP8, VP9, AV1, H264, H265) and defaulting
to `MaintainResolution` degradation preference.

This addresses the issue where video starts blurry for several seconds
before improving, by:
1. Telling WebRTC's bandwidth estimator to start at 70% of target
bitrate instead of ramping up from ~300kbps
2. Preferring frame drops over resolution reduction when bandwidth is
constrained

The `DegradationPreference` option is now exposed via FFI for Python,
C++, Unity, and Node SDKs.

### Add `MaintainFramerateAndResolution` to `DegradationPreference` enum
to align with WebRTC M144.

- `MAINTAIN_FRAMERATE_AND_RESOLUTION` is now the recommended value
(replaces deprecated `DISABLED`)
- `DISABLED` is deprecated but still supported for backwards
compatibility
- Both values map to the same behavior: maintain framerate and
resolution, dropping frames if needed

## Fixes

- Fix AV1 subscriber decode when packet trailers are enabled.
# livekit-ffi 0.12.68 (2026-06-30)
## Features

- Add `user_data` support to frame metadata, allowing arbitrary
application-supplied bytes to be attached to a video frame via the
`PTF_USER_DATA` packet trailer feature.

### Improve initial video quality by setting `x-google-start-bitrate`
SDP hint for all video codecs (VP8, VP9, AV1, H264, H265) and defaulting
to `MaintainResolution` degradation preference.

This addresses the issue where video starts blurry for several seconds
before improving, by:
1. Telling WebRTC's bandwidth estimator to start at 70% of target
bitrate instead of ramping up from ~300kbps
2. Preferring frame drops over resolution reduction when bandwidth is
constrained

The `DegradationPreference` option is now exposed via FFI for Python,
C++, Unity, and Node SDKs.

### Add `MaintainFramerateAndResolution` to `DegradationPreference` enum
to align with WebRTC M144.

- `MAINTAIN_FRAMERATE_AND_RESOLUTION` is now the recommended value
(replaces deprecated `DISABLED`)
- `DISABLED` is deprecated but still supported for backwards
compatibility
- Both values map to the same behavior: maintain framerate and
resolution, dropping frames if needed

## Fixes

- Fix AV1 subscriber decode when packet trailers are enabled.
- Improve log messages around plugin loading - #1186 (@lukasIO)
# livekit-protocol 0.7.10 (2026-06-30)
## Features

- Add `user_data` support to frame metadata, allowing arbitrary
application-supplied bytes to be attached to a video frame via the
`PTF_USER_DATA` packet trailer feature.
# livekit 0.7.50 (2026-06-30)
## Features

- Add `user_data` support to frame metadata, allowing arbitrary
application-supplied bytes to be attached to a video frame via the
`PTF_USER_DATA` packet trailer feature.

### Improve initial video quality by setting `x-google-start-bitrate`
SDP hint for all video codecs (VP8, VP9, AV1, H264, H265) and defaulting
to `MaintainResolution` degradation preference.

This addresses the issue where video starts blurry for several seconds
before improving, by:
1. Telling WebRTC's bandwidth estimator to start at 70% of target
bitrate instead of ramping up from ~300kbps
2. Preferring frame drops over resolution reduction when bandwidth is
constrained

The `DegradationPreference` option is now exposed via FFI for Python,
C++, Unity, and Node SDKs.

### Add `MaintainFramerateAndResolution` to `DegradationPreference` enum
to align with WebRTC M144.

- `MAINTAIN_FRAMERATE_AND_RESOLUTION` is now the recommended value
(replaces deprecated `DISABLED`)
- `DISABLED` is deprecated but still supported for backwards
compatibility
- Both values map to the same behavior: maintain framerate and
resolution, dropping frames if needed

## Fixes

- Fix AV1 subscriber decode when packet trailers are enabled.
- Improve log messages around plugin loading - #1186 (@lukasIO)

Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants