feat: add MaintainFramerateAndResolution to DegradationPreference enum - #1200
Merged
Conversation
xianshijing-lk
requested review from
MaxHeimbrock,
alan-george-lk,
cloudwebrtc,
ladvoc and
stephen-derosa
as code owners
June 30, 2026 03:20
Contributor
ChangesetThe following package versions will be affected by this PR:
|
Aligns the DegradationPreference enum with WebRTC M144 changes: - Add MAINTAIN_FRAMERATE_AND_RESOLUTION as the new recommended value - Deprecate DISABLED (maps to MAINTAIN_FRAMERATE_AND_RESOLUTION for backwards compatibility) Changes: - room.proto: Add DEGRADATION_PREFERENCE_MAINTAIN_FRAMERATE_AND_RESOLUTION - webrtc-sys: Rename Disabled to MaintainFramerateAndResolution in enum - libwebrtc: Add MaintainFramerateAndResolution variant, deprecate Disabled as const alias - livekit-ffi: Update conversion to handle both old and new proto values Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
xianshijing-lk
force-pushed
the
sxian/update-degradation-preference-enum
branch
from
June 30, 2026 03:21
ffef361 to
3271ab9
Compare
cloudwebrtc
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the DegradationPreference enum with WebRTC M144 changes:
MAINTAIN_FRAMERATE_AND_RESOLUTIONas the new recommended valueDISABLED(maps toMAINTAIN_FRAMERATE_AND_RESOLUTIONfor backwards compatibility)Reference: https://github.com/webrtc-sdk/webrtc/blob/m144_release/api/rtp_parameters.h#L125
Changes
DEGRADATION_PREFERENCE_MAINTAIN_FRAMERATE_AND_RESOLUTIONenum valueDisabledtoMaintainFramerateAndResolutionin the repr(i32) enumMaintainFramerateAndResolutionvariant, deprecateDisabledas a const aliasDISABLEDand newMAINTAIN_FRAMERATE_AND_RESOLUTIONproto valuesBackwards Compatibility
DISABLEDwill continue to work (mapped toMaintainFramerateAndResolution)Test plan
cargo build -p livekit-ffipassescargo build -p livekitpassescargo test -p livekit --lib -- degradationpasses🤖 Generated with Claude Code