Skip to content

Fix object constructor error throwing issue #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1egoman merged 2 commits into from
Jan 13, 2026
Merged

Fix object constructor error throwing issue #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35cdf73
fix: ensure that constructor functions can throw errors
1egoman Jan 13, 2026
e06c830
fix: use ErrorEnumAndVariant type
1egoman Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions templates/node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,8 +379,15 @@ export class {{ object_def.name() | typescript_class_name }} extends UniffiAbstr
let {{ arg.name() | typescript_argument_var_name }} = {{ arg.name() | typescript_var_name | typescript_ffi_converter_lower_with(arg.as_type().borrow()) }};
{% endfor -%}

const pointer = uniffiCaller.rustCall(
/*caller:*/ (callStatus) => {
const pointer = {%- match constructor_fn.throws_type() -%}
{%- when Some(err) -%}
uniffiCaller.rustCallWithError(
/*liftError:*/ (buffer) => ["{{err | typescript_type_name}}", {{err | typescript_ffi_converter_name}}.lift(buffer)],
/*caller:*/ (callStatus) => {
{%- else -%}
uniffiCaller.rustCall(
/*caller:*/ (callStatus) => {
{%- endmatch %}
return FFI_DYNAMIC_LIB.{{ constructor_fn.ffi_func().name() }}([
{% for arg in constructor_fn.arguments() -%}
{{ arg.name() | typescript_argument_var_name }}
Expand Down
2 changes: 1 addition & 1 deletion templates/sys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class UniffiFfiRsRustCaller {
function uniffiCheckCallStatus<ErrorEnumAndVariant extends [string, string]>(
callStatus: UniffiRustCallStatusStruct,
liftString: (bytes: UniffiByteArray) => string,
liftError?: (buffer: UniffiByteArray) => [string, string],
liftError?: (buffer: UniffiByteArray) => ErrorEnumAndVariant,
) {
switch (callStatus.code) {
case CALL_SUCCESS:
Expand Down