fix: replace {{PROJECT_NAME}} template placeholders#8
Open
chcost wants to merge 1 commit into
Open
Conversation
The repo was scaffolded from a template but the placeholders were never replaced, causing CI failures: go.mod has an invalid module path, Dockerfile fails on missing go.sum, and Makefile targets reference the wrong project/registry. - go.mod: set module to github.com/llm-d-incubation/llm-d-resiliency-operator - Makefile: set PROJECT_NAME and REGISTRY to actual values - Dockerfile: use go.sum* glob since no external deps exist yet Signed-off-by: Carlos H. Andrade Costa <carlos@andradecosta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{{PROJECT_NAME}}placeholders were never replaced, causinglint-and-testandcontainer-buildCI jobs to fail on every PR since repo creationgo.mod: invalid module pathgithub.qkg1.top/llm-d/{{PROJECT_NAME}}→github.com/llm-d-incubation/llm-d-resiliency-operatorMakefile: setPROJECT_NAMEtollm-d-resiliency-operator,REGISTRYtoghcr.io/llm-d-incubation, fix OCI source annotation URLDockerfile: useCOPY go.mod go.sum* ./glob since there are no external dependencies yet (nogo.sumto copy)Test plan
lint-and-testCI job passescontainer-buildCI job passesmake buildworks locally