Skip to content

enh: update helm charts to new llm-d-async config values - #636

Draft
evacchi wants to merge 4 commits into
llm-d:mainfrom
evacchi:async-processor-config-migration
Draft

enh: update helm charts to new llm-d-async config values#636
evacchi wants to merge 4 commits into
llm-d:mainfrom
evacchi:async-processor-config-migration

Conversation

@evacchi

@evacchi evacchi commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Why is this PR needed?

llm-d-async PRs llm-d/llm-d-async#388 and llm-d/llm-d-async#378 update to a cleaner config format; even though the old format is supported, we can keep the two codebases tightly aligned and avoid deprecation warnings.

What does this PR do?

Updates the Helm charts, scripts and tests to align to the llm-d-async codebase. Since the change is not merged yet, this PR is draft, and we might wait for a formal release before merging.

How was this tested?

  • Unit tests added/updated/verified
  • Integration/e2e tests added/updated/verified
  • Manual testing performed

Checklist

  • Commits are signed off (git commit -s) per DCO
  • Code follows project contributing guidelines
  • CI checks pass (make ci)
  • E2E tests pass (make test-e2e)

Related Issues

llm-d/llm-d-async#388 and llm-d/llm-d-async#378

@github-actions github-actions Bot added the enhancement New user-facing capability label Aug 3, 2026
@evacchi
evacchi force-pushed the async-processor-config-migration branch from 8cee818 to e7db731 Compare August 6, 2026 15:26
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Unsigned commits detected! Please sign your commits.

For instructions on how to set up GPG/SSH signing and verify your commits, please see GitHub Documentation.

@evacchi
evacchi force-pushed the async-processor-config-migration branch from e7db731 to 964aa4a Compare August 6, 2026 16:06
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
@evacchi
evacchi force-pushed the async-processor-config-migration branch from 964aa4a to dade6ec Compare August 20, 2026 12:56
@evacchi
evacchi marked this pull request as ready for review August 20, 2026 12:56
Copilot AI lite review requested due to automatic review settings August 20, 2026 12:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s e2e configs, deployment scripts, and documentation to match the newer llm-d-async configuration schema and naming (e.g., ap.transport / ap.transportConfig and llm-d-async chart/deployment identifiers), keeping batch-gateway aligned with the upstream dispatcher project.

Changes:

  • Switched dispatcher Helm values from messageQueueImpl/redis.* to transport/transportConfig across e2e values, examples, docs, and benchmark deployment.
  • Updated scripts and e2e logic to look for llm-d-async naming (chart path and deployment/service identifiers).
  • Refreshed trace/e2e documentation strings to refer to llm-d-async instead of async-processor.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/e2e/dispatcher/helm-values.yaml Updates dispatcher Helm values to the new transport-based config format.
test/e2e/dispatcher/helm-values-scrape.yaml Same as above for endpoint-scrape gate scenario.
test/e2e/dispatcher/helm-values-prometheus.yaml Same as above for prometheus-query gate scenario.
test/e2e/dispatcher_test.go Updates e2e detection/comments to match llm-d-async naming.
test/e2e/dispatcher_otel_test.go Updates Jaeger query/service naming and comments for llm-d-async.
scripts/dev-deploy-dispatcher.sh Updates chart reference and deployment wait targets to llm-d-async.
examples/deploy-demo/deploy-k8s.sh Updates demo deploy script chart/image and values to new transport config + new deployment name.
docs/guides/deploy-k8s.md Updates deployment guide snippets for new chart/image and transport config values.
docs/design/batch-dispatcher-queue-design.md Updates design doc to describe the new transport-config document format.
benchmarks/setup.sh Updates benchmark scenario deployment flags and wait target to match new chart/resource naming.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

"max_concurrency": "100",
"baseline": "0.05"
{
"result_queue_name": "llm-d-async:results:optimized-baseline:$batch",
@evacchi
evacchi marked this pull request as draft August 20, 2026 13:12
@evacchi

evacchi commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

re-drafting no upstream release yet

Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
@zdtsw zdtsw added the v0.6.0 label Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New user-facing capability v0.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants