add pr_number/pr_repo inputs to OCP helmfile reusable workflow - #171
Open
sudoalok wants to merge 3 commits into
Open
add pr_number/pr_repo inputs to OCP helmfile reusable workflow#171sudoalok wants to merge 3 commits into
sudoalok wants to merge 3 commits into
Conversation
Signed-off-by: Alok Behera <alokbeherak061@gmail.com>
Signed-off-by: Alok Behera <alokbeherak061@gmail.com>
The reusable-nightly-e2e-openshift-helmfile.yaml workflow was missing pr_number and pr_repo inputs. Caller workflows (pd-disaggregation-ocp, wide-ep-lws-ocp) were passing these values but they were silently ignored, preventing PR comment-back. Closes #1566 Signed-off-by: Alok Behera <alokbeherak061@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1566
What was broken
The OCP helmfile reusable workflow was missing
pr_numberandpr_repoinputs. The caller workflows for
pd-disaggregation-ocpandwide-ep-lws-ocpwere already passing these values — they just hadnowhere to land, so nightly runs never commented back on the PR.
Fix
Added the two missing input declarations and a "Comment on PR" step.
The step is identical to what
reusable-nightly-e2e-gke.yamlalreadydoes — just copied the pattern across.
Changed
.github/workflows/reusable-nightly-e2e-openshift-helmfile.yaml