fix(ci): capture pod state and events when OCP pods time out - #173
Open
sudoalok wants to merge 1 commit into
Open
fix(ci): capture pod state and events when OCP pods time out#173sudoalok wants to merge 1 commit into
sudoalok wants to merge 1 commit into
Conversation
When pods fail to become ready, the previous diagnostic only described pods with phase!=Running — missing pods that are Running but not Ready (e.g. failing health checks). Kubernetes events were also not captured, making the root cause opaque. Fixed by checking Ready condition instead of phase, adding event capture, and uploading a timeout-diagnostics artifact on failure. Closes #1570 Signed-off-by: Alok Behera <alokbeherak061@gmail.com>
Contributor
|
/assign @maugustosilva |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes llm-d/llm-d#1570
What was missing
When pods didn't become ready in time, the diagnostic only described
pods where
phase != Running. The problem is a pod can be inRunningphase but still not
Ready— for example if a health check is failing.Those pods were completely skipped, so the logs had nothing useful.
On top of that, Kubernetes events were never captured. Events are
usually the first place you look to understand why a pod isn't starting
— things like image pull failures, volume mount errors, OOM kills, etc.
What this PR does
Readycondition instead ofphaseto find stuck podskubectl get eventscapture at timeout timepod-timeout-diagnosticsartifact on failureso the next time this happens, the data is right there
Applies to both
reusable-nightly-e2e-openshift.yamlandreusable-nightly-e2e-openshift-helmfile.yaml.This doesn't fix why pods aren't becoming ready — that needs the
artifact data first. But at least the next failure won't be opaque.