fix(ci): fix TPU request job cleanup and idempotency on DWS timeout - #234
Open
nicolexin wants to merge 1 commit into
Open
fix(ci): fix TPU request job cleanup and idempotency on DWS timeout#234nicolexin wants to merge 1 commit into
nicolexin wants to merge 1 commit into
Conversation
Collaborator
|
Hey @nicolexin. Apologies for the long delay in reviewing it (we just had the release |
nicolexin
force-pushed
the
fix/tpu-dws-232
branch
from
August 20, 2026 20:45
2cfa62f to
329cdbf
Compare
Author
|
Hi @maugustosilva I have rebased the change, PTAL and thank you! |
…lm-d#232) Signed-off-by: Nicole Xin <nxin@google.com>
nicolexin
force-pushed
the
fix/tpu-dws-232
branch
from
August 20, 2026 20:49
329cdbf to
26a3eb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Problem
In
reusable-ci-nightly-benchmark.yamlandreusable-nightly-e2e-gke-tpu.yaml, thetpu-request-jobcleanup command (kubectl delete job tpu-request-job) was placed at the end of theRequest TPUs (DWS)step afterkubectl wait. Whenkubectl waittimed out due to TPU capacity constraints:llmdbenchmarkwas not installed, causing the teardown step to skip namespace cleanup.kubectl applyreturnedunchangedwithout spawning new pods, causingkubectl waitto immediately fail witherror: no matching resources found, latching the pipeline red.Solution
kubectl delete job tpu-request-job -n "$NS" --ignore-not-foundbefore applying the job manifest.Release TPU Request Jobstep withif: always() && steps.infra_request_tpus.outcome != 'skipped'so the job is deleted even ifkubectl waittimes out or fails.Why is this change needed?
See #232
How was this tested?
Will need to verify in CI/CD. The change itself is very small though.
Checklist
git commit -s) per DCOmake test)make lint)Related Issues