fix format files - #251
Open
diegocastanibm wants to merge 2 commits into
Open
Conversation
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
diegocastanibm
requested review from
Gregory-Pereira and
clubanderson
as code owners
September 1, 2026 16:46
diegocastanibm
requested review from
Gregory-Pereira and
maugustosilva
and removed request for
Gregory-Pereira and
clubanderson
September 1, 2026 16:46
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the pre-commit backlog (363 → 0 findings)
Follow-up to #250, which added
actionlintwith the shellcheck backlog suppressedvia
-shellcheck=and-ignore. This fixes the underlying issues and removes bothsuppressions, so
pre-commit run --all-filespasses with the hook fully enabled.First:
mainis currently redBefore touching the backlog,
actionlintfailed even with the suppressions inplace. #243 (ROCm, merged after #250) added
runs-on: rocmwithout declaring thelabel in
.github/actionlint.yaml. pre-commit is not a required check yet, sonothing blocked it. Adding
rocmto the label list unbreaksmainon its own.Verification
run:blocks from the parsed YAML: 0 bash syntax errors.Same 171 before and after, so no step was dropped.
beforewas alreadysyntax-clean, so this confirms preservation rather than a fix.
comparing stdout plus the summary/output/env files: 60 byte-identical. The 20
that first appeared to differ carried only bash's own error text with shifted
line numbers.
oc adm … -n "${NAMESPACE}", visible only becausethe harness left
NAMESPACEunset. Unreachable in practice: the input isrequired: true, and the line directly above already runskubectl create namespace "$NAMESPACE"quoted, so an empty value fails a lineearlier.