Skip to content

fix format files - #251

Open
diegocastanibm wants to merge 2 commits into
llm-d:mainfrom
diegocastanibm:fix-files
Open

fix format files#251
diegocastanibm wants to merge 2 commits into
llm-d:mainfrom
diegocastanibm:fix-files

Conversation

@diegocastanibm

Copy link
Copy Markdown
Collaborator

Fix the pre-commit backlog (363 → 0 findings)

Follow-up to #250, which added actionlint with the shellcheck backlog suppressed
via -shellcheck= and -ignore. This fixes the underlying issues and removes both
suppressions, so pre-commit run --all-files passes with the hook fully enabled.

First: main is currently red

Before touching the backlog, actionlint failed even with the suppressions in
place
. #243 (ROCm, merged after #250) added runs-on: rocm without declaring the
label in .github/actionlint.yaml. pre-commit is not a required check yet, so
nothing blocked it. Adding rocm to the label list unbreaks main on its own.

Verification

  • All 9 hooks pass with both suppressions removed.
  • Extracted all 171 run: blocks from the parsed YAML: 0 bash syntax errors.
    Same 171 before and after, so no step was dropped. before was already
    syntax-clean, so this confirms preservation rather than a fix.
  • Executed all 61 changed blocks before-and-after with cluster tools stubbed,
    comparing stdout plus the summary/output/env files: 60 byte-identical. The 20
    that first appeared to differ carried only bash's own error text with shifted
    line numbers.
  • The 1 remaining difference is oc adm … -n "${NAMESPACE}", visible only because
    the harness left NAMESPACE unset. Unreachable in practice: the input is
    required: true, and the line directly above already runs
    kubectl create namespace "$NAMESPACE" quoted, so an empty value fails a line
    earlier.

Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant