Skip to content

fix: correct eis to is variable name in prediction_server.py - #72

Open
Jah-yee wants to merge 1 commit into
llm-d:mainfrom
Jah-yee:fix/eis-to-is-typo
Open

fix: correct eis to is variable name in prediction_server.py#72
Jah-yee wants to merge 1 commit into
llm-d:mainfrom
Jah-yee:fix/eis-to-is-typo

Conversation

@Jah-yee

@Jah-yee Jah-yee commented Aug 1, 2026

Copy link
Copy Markdown

Summary

Per the typo scan in issue #71, this PR corrects the variable name eis to is in two locations:

  • Line 767: eis = np.fromiter(...)is = np.fromiter(...)
  • Line 800: df_ttft_raw["encoder_input_size"] = eisdf_ttft_raw["encoder_input_size"] = is

Fix

-                eis = np.fromiter((r.encoder_input_size for r in reqs), dtype=np.float64, count=n)
+                is = np.fromiter((r.encoder_input_size for r in reqs), dtype=np.float64, count=n)
-                df_ttft_raw["encoder_input_size"] = eis
+                df_ttft_raw["encoder_input_size"] = is

Fixes #71

@Jah-yee
Jah-yee requested a review from ahg-g as a code owner August 1, 2026 04:05
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

Unsigned commits detected! Please sign your commits.

For instructions on how to set up GPG/SSH signing and verify your commits, please see GitHub Documentation.

@Jah-yee
Jah-yee force-pushed the fix/eis-to-is-typo branch 5 times, most recently from ee8392d to 5877aac Compare August 6, 2026 16:20
@Jah-yee

Jah-yee commented Aug 15, 2026

Copy link
Copy Markdown
Author

Friendly ping — any updates? Happy to address feedback. This is a simple typo fix (eis→is) from a typo scan.

eis → is per typo scan in prediction_server.py

Fixes llm-d#71

Signed-off-by: Jah-yee <166608075+Jah-yee@users.noreply.github.com>
@Jah-yee
Jah-yee force-pushed the fix/eis-to-is-typo branch from 5877aac to 494a64b Compare August 15, 2026 15:14
@Jah-yee

Jah-yee commented Aug 16, 2026

Copy link
Copy Markdown
Author

Friendly ping — this PR has been waiting 15 days without a review. Happy to address any feedback or make adjustments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typos detected by nightly scan (2 found)

1 participant