feat(helm): support configuring Envoy IPv6 listening via Helm value#1970
Open
weizhoublue wants to merge 1 commit into
Open
feat(helm): support configuring Envoy IPv6 listening via Helm value#1970weizhoublue wants to merge 1 commit into
weizhoublue wants to merge 1 commit into
Conversation
github-actions
Bot
added
size/XS
Contributor
Author
|
@eating-chen @ahg-g This is a follow-up for PR #1920 . I think there should be a toggle to support ipv6 more elegantly. Please help check whether it makes sense, thanks |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a Helm value toggle to control whether the standalone chart’s Envoy proxy binds an IPv6 wildcard listener (::) via additional_addresses, avoiding startup bind failures in IPv4-only environments where IPv6 is disabled at the kernel level.
Changes:
- Introduces
.Values.router.proxy.ipv6(defaultfalse) to control IPv6 listener binding. - Conditionally renders Envoy
additional_addressesblocks for the readiness listener (19001) and HTTP listener (8081) based on that value.
github-actions
Bot
added
size/S
Signed-off-by: weizhou.lan@daocloud.io <weizhou.lan@daocloud.io>
weizhoublue
force-pushed
the
fix-envoy-ipv6-optional
branch
from
390a3fc to
4f1420f
Compare
github-actions
Bot
added
kind/feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
For IPv6 support, we should handle it more elegantly by introducing a Helm toggle to let users manually enable or disable it.
IPv6 is not a mandatory requirement. In IPv4-only environments where the Linux kernel has
net.ipv6.conf.all.disable_ipv6=1, forcing Envoy to listen on IPv6 causes startup bind failures, leading to process exit. Currently, users must manually edit the chart source code to disable this behavior.Adding a Helm value option allows users to toggle this feature based on their environment, or enables upstream chart integrations to control it programmatically.
This better conforms to some conventions for network‑related components.
I recommend disabling this toggle by default. Enabling it directly may impose additional requirements on deployment.
Which issue(s) this PR fixes:
Fixes #
Release note (write
NONEif no user-facing change):