fix: warn when refresh-metrics-interval exceeds metricsStalenessThres… - #2645
Open
varad-ahirwadkar wants to merge 1 commit into
Open
fix: warn when refresh-metrics-interval exceeds metricsStalenessThres…#2645varad-ahirwadkar wants to merge 1 commit into
varad-ahirwadkar wants to merge 1 commit into
Conversation
varad-ahirwadkar
requested review from
a team,
LukeAVanDrie and
RishabhSaini
as code owners
September 1, 2026 12:41
github-actions
Bot
added
size/L
ahg-g
reviewed
Sep 2, 2026
ahg-g
left a comment
ahg-g
left a comment
Collaborator
There was a problem hiding this comment.
I don't recommend expanding and adding yet another interface, instead we can put this in the handle within a perhaps metadata struct that the plugin can check and do whatever it sees fit (fail creation, warn etc.).
Contributor
Author
|
Hi @ahg-g |
varad-ahirwadkar
force-pushed
the
flowcontrol
branch
from
September 3, 2026 04:42
f82f929 to
5db0852
Compare
github-actions
Bot
added
area/dev
…hold Signed-off-by: Varad Ahirwadkar <varad.ahirwadkar1@ibm.com>
varad-ahirwadkar
force-pushed
the
flowcontrol
branch
from
September 3, 2026 05:14
5db0852 to
5bd60d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When
--refresh-metrics-intervalexceeds a saturation detector'smetricsStalenessThreshold, endpoint metrics may become stale between polls. This can cause the detector to treat healthy endpoints as saturated, leading to backpressure and increased request latency.This PR adds a startup warning that identifies the detector and both effective values, helping operators detect and correct the configuration before serving traffic.
Which issue(s) this PR fixes:
Fixes #2514
Release note (write
NONEif no user-facing change):