fix(epp): move TokenizedPrompt to request attribute store (#1375) - #2653
fix(epp): move TokenizedPrompt to request attribute store (#1375)#2653yuanhuizang-cloud wants to merge 1 commit into
Conversation
|
🚨 Unsigned commits detected! Please sign your commits. For instructions on how to set up GPG/SSH signing and verify your commits, please see GitHub Documentation. |
49b3374 to
1f27d41
Compare
Signed-off-by: yhzang <yuanhuizang@gmail.com>
1f27d41 to
d85dad5
Compare
|
I am not confident that this is strictly necessary and the value it adds, the change is significant. |
|
Thanks for the feedback. I agree the footprint is broad, so the value should justify the cost. The main value I see is aligning the framework contract with runtime behavior: The footprint is broad, but the semantic change is relatively narrow: most production changes are consumers switching from I agree the size of the migration is the main trade-off here. If there is a smaller way to achieve the same alignment, I'm happy to adjust the implementation. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Moves TokenizedRequest out of InferenceRequestBody and stores it in the per-request attribute store under TokenizedPromptDataKey.
TokenizedPromptDataKey was already used to declare producer/consumer dependencies, while the actual tokenized prompt was still stored and accessed through InferenceRequestBody.TokenizedRequest. This made the declared dependency graph and the runtime data flow use two different mechanisms for the same data.
This PR aligns them by:
This removes the previous hidden body mutation path and avoids maintaining multiple sources of truth for tokenized prompt state.
Which issue(s) this PR fixes:
Fixes #1375
Release note (write
NONEif no user-facing change):