Skip to content

[mlir][logo] add MLIR Sparsifier GIF assets to website#166

Merged
joker-eph merged 2 commits into
llvm:mainfrom
aartbik:bik
Jan 11, 2024
Merged

[mlir][logo] add MLIR Sparsifier GIF assets to website#166
joker-eph merged 2 commits into
llvm:mainfrom
aartbik:bik

Conversation

@aartbik

@aartbik aartbik commented Jan 5, 2024

Copy link
Copy Markdown
Contributor

Logos for the MLIR Sparsifier project, combining the MLIR logo with the concept of a sparse tensor.

Credit:
these beautiful MLIR Sparsifier GIF logos were designed by Yinying Li

Logos for the MLIR Sparsifier project, combining the MLIR logo with
the concept of a sparse tensor.

Credit:
this beautiful MLIR Sparsifier GIF logos were designed by Yinying Li
@yinying-lisa-li

Copy link
Copy Markdown

Thanks Aart!

@joker-eph

Copy link
Copy Markdown
Contributor

Is there a license?

@aartbik

aartbik commented Jan 5, 2024

Copy link
Copy Markdown
Contributor Author

Is there a license?

Was there a license for the original MLIR logos? If so, we can release these under the same (assuming that is okay).

@aartbik

aartbik commented Jan 5, 2024

Copy link
Copy Markdown
Contributor Author

@jpienaar to comment on licensing

@jpienaar

jpienaar commented Jan 5, 2024

Copy link
Copy Markdown
Member

#132 is an ongoing discussion on making it clearer.

@jpienaar jpienaar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder where it should go, e.g., the LogoAssets/logo is for the MLIR logo, I wonder if for subprojects it may make sense in LogoAssets/ instead (else folks could think its just the gif file format variant of the logo)

@aartbik

aartbik commented Jan 5, 2024

Copy link
Copy Markdown
Contributor Author

I wonder where it should go, e.g., the LogoAssets/logo is for the MLIR logo, I wonder if for subprojects it may make sense in LogoAssets/ instead (else folks could think its just the gif file format variant of the logo)

Yeah, good question. I tried to address this by using the extra /sparsifier level (I had to add the GIF top level since we were the first to provide a GIF logo). If you think LogoAssets/Sparsifier/GIF is better, happy to move it.

@joker-eph

Copy link
Copy Markdown
Contributor

LogoAssets/Sparsifier/GIF seems better for me. I suspect the author of the logo needs to transfer the copyright to the LLVM foundation? I don't know if a comment here is enough for this or what.

@yinying-lisa-li

Copy link
Copy Markdown

No problem! I'm happy to transfer the copyright to the LLVM foundation. Please feel free to let me know if there's anything else you need.

to make it clear this is a subproject. Below that
we follow the same file type convention and thus
use GIF for these moving logos.
@aartbik

aartbik commented Jan 5, 2024

Copy link
Copy Markdown
Contributor Author

Moved the assets into static/LogoAssets/Sparsifier/ to make it more clear this is a subproject. Below that we follow the same convention to use file types, so that gives static/LogoAssets/Sparsifier/GIF for these logos.

@yinying-lisa-li thank you again for this beautiful artwork and your verbal transfer of copyright to LLVM foundation.

@aartbik

aartbik commented Jan 9, 2024

Copy link
Copy Markdown
Contributor Author

Can we proceed with this PR, or do we need a full resolution of #132 first?

@joker-eph joker-eph merged commit 67bdf7a into llvm:main Jan 11, 2024
@aartbik aartbik deleted the bik branch January 16, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants