[OnnxToTorch] Lower onnx.MeanVarianceNorm to torch dialect without expansion#4219
Merged
Conversation
zahidwx
changed the title
onnx.MeanVarianceNorm to torch dialect without expansion
zahidwx
force-pushed
the
feature/onnx-mvn
branch
2 times, most recently
from
643883e to
ac5ce26
Compare
Contributor
Author
|
Thoughts on this PR? Also checkout the related issue behind this PR - @vivekkhandelwal1 | @rsuderman | @stellaraccident | @ScottTodd |
vivekkhandelwal1
requested changes
Jun 30, 2025
Signed-off-by: Zahid Wakeel <zahid.wakeel@multicorewareinc.com>
Signed-off-by: Zahid Wakeel <zahid.wakeel@multicorewareinc.com>
Signed-off-by: Zahid Wakeel <zahid.wakeel@multicorewareinc.com>
Signed-off-by: Zahid Wakeel <zahid.wakeel@multicorewareinc.com>
zahidwx
force-pushed
the
feature/onnx-mvn
branch
from
338213f to
c9fe057
Compare
vivekkhandelwal1
approved these changes
Jul 15, 2025
Collaborator
vivekkhandelwal1
left a comment
vivekkhandelwal1
left a comment
There was a problem hiding this comment.
LGTM, except my query related to one of my previous comments.
Add negative axes lit tests for MVN Signed-off-by: Zahid Wakeel <zahid.wakeel@multicorewareinc.com>
zahidwx
force-pushed
the
feature/onnx-mvn
branch
from
338518b to
801ba0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes care of #4218.