[bug] Fix decomposition logic for logaddexp#4509
Open
Conversation
Signed-off-by: Vihang Mehta <vihang@gimletlabs.ai>
vihangm
force-pushed
the
vihang/logaddexp_broadcast
branch
from
044617b to
b912b25
Compare
Author
|
@penguin-wwy or @vivekkhandelwal1 let me know if you'd be able to review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The result types on the exp ops during decomposition were incorrect. The AddTensorOp is where the auto broadcasting happens so the exp ops should propagate the input type as their output type.
I added a couple of tests that exhibit the issue, and fail without this patch but pass after.
This was broken from the original implementation in #4201
Signed-off-by: Vihang Mehta vihang@gimletlabs.ai