Skip to content

[Windows] Use math extras instead of M_PI#4512

Draft
zjgarvey wants to merge 1 commit intomainfrom
users/zjgarvey/fix_windows_build
Draft

[Windows] Use math extras instead of M_PI#4512
zjgarvey wants to merge 1 commit intomainfrom
users/zjgarvey/fix_windows_build

Conversation

@zjgarvey
Copy link
Copy Markdown
Collaborator

Signed-off-by: zjgarvey <zjgarvey@gmail.com>
@zjgarvey
Copy link
Copy Markdown
Collaborator Author

@annop-w
Copy link
Copy Markdown
Contributor

annop-w commented Mar 23, 2026

@zjgarvey Thank you for fixing. Could you please replace M_LOG10E in lib/Conversion/TorchOnnxToTorch/DefaultDomainGtoP.cpp and M_2_PI in lib/Conversion/TorchToStablehlo/Basic.cpp and lib/Conversion/TorchToTosa/TorchToTosa.cpp as well ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants