[TMTensor] Add is_causal attribute to aid mask dematerialisation.#4520
Open
keshavvinayak01 wants to merge 2 commits intollvm:mainfrom
Open
[TMTensor] Add is_causal attribute to aid mask dematerialisation.#4520keshavvinayak01 wants to merge 2 commits intollvm:mainfrom
keshavvinayak01 wants to merge 2 commits intollvm:mainfrom
Conversation
Add OptionalAttr<BoolAttr>:$is_causal to signal that the materialized mask is a causal mask. Downstream consumers can use this to replace the mask with a fused index computation. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
keshavvinayak01
force-pushed
the
users/keshavvinayak01/TMTensor-causal-mask-attr
branch
from
2ab61c0 to
51e62e7
Compare
keshavvinayak01
requested review from
Yu-Zhewen and
zjgarvey
and removed request for
zjgarvey
keshavvinayak01
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the
is_causalhint removes unnecessary buffer allocations and enables fusion opportunities downstream. (Optionally, the downstream lowering can let the mask be allocated, preserving previous behaviour)(Example: iree-org/iree#23999)