avoid dropping the wrapped scripts stdin#119
Open
v4hn wants to merge 1 commit intolocusrobotics:masterfrom
Open
avoid dropping the wrapped scripts stdin#119v4hn wants to merge 1 commit intolocusrobotics:masterfrom
v4hn wants to merge 1 commit intolocusrobotics:masterfrom
Conversation
This way `rosrun <pkg> <script>` is still able to read user input from the command line (usually for prompts).
v4hn
force-pushed
the
fix-stdin-in-wrapped-scripts
branch
from
d9c0ecd to
a6fe7a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just wrote a short CLI prompt script that exited directly when wrapped through
catkin_virtualenv. It turns out the script accidentally overwrote STDIN.Instead I moved the internal code passing to fd=3 instead.
This way
rosrun <pkg> <script>is still able to read user input from the command line (usually for prompts).