This repository was archived by the owner on Sep 16, 2023. It is now read-only.
Support module directories with index.js#175
Open
albertogasparin wants to merge 1 commit intolodash:masterfrom
Open
Support module directories with index.js#175albertogasparin wants to merge 1 commit intolodash:masterfrom
albertogasparin wants to merge 1 commit intolodash:masterfrom
Conversation
1 task
albertogasparin
force-pushed
the
support-module-dirs
branch
from
b7387d0 to
78753f2
Compare
|
@albertogasparin Do you mean |
Contributor
|
This is siiiiiick. Any updates? |
Contributor
Author
|
@AndersDJohnson Those where the names of lodash methods I've used to match folder naming. But I've made it more clear. |
|
Is there any plan to merge this PR? Do you need any help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a folder contains
index.js, then we add the folder name as an available namespace in the plugin cache. Moreover, we try to handle different styles for dir names (lowercase, kebab-case and snakeCase).This should be a nice step forward to make this plugin a generic solution to reduce imports and improve tree shaking.
Closes #166