Partially fixes #298 - make apps pluggable#299
Conversation
|
@djmgit I think this PR will cause redundancy and space wastage. |
|
@kavithaenair Its true that this will introduce redundancy, presently the apps have got their dependencies distributed in different folders (like js and css in root directory), so the apps are not standalone. The aim of this PR is to make the apps standalone so that any one can use an app independently (simply copy the app folder and use it somewhere else without caring about the dependencies). But that is only possible when the apps have all their dependencies with them (In the same folder) or else users will also have to manage the app dependencies as well that is also take care of the root js, css and images folder which contains dependencies of all apps. @Achint08 @hemantjadon @vibhcool @kavithaenair @singhpratyush @SKrPl what do you all suggest? |
|
IMHO Space shall not be much of the issue. If this PR keeps each app independent of each other and the website code and app code is kept separately, then this PR is fine. |
Partially fixes issue - loklak#298, moved the following apps' dependencies into their individual folders and updated script and css references. ``` barchart boilerplate bubblecharts collegeElections compareTwitterProfiles CountryTweetMap ducphanduy emojiheatmap emojiheatmapper fossasia-histogram histogram knowthediff LQL MultiLinePlotter ```
|
Test link: klakapps.surge.sh @kavithaenair @vibhcool open for review. |
Partially fixes #298 - made apps pluggable
I have:
Fixes #<number> commit messageFor the reviewers
I have: