Skip to content

server: reverse: fix kwargs type annotation#634

Merged
fscherf merged 1 commit into
lona-web-org:masterfrom
janheini:fix-reverse-type-annotation
Apr 23, 2026
Merged

server: reverse: fix kwargs type annotation#634
fscherf merged 1 commit into
lona-web-org:masterfrom
janheini:fix-reverse-type-annotation

Conversation

@janheini

Copy link
Copy Markdown
Contributor

Hey,

when annotating kwargs the type annotation refers to the type of the items within the dict 1. This is already done correctly around the codebase, except for Server.reverse.

Let's drop the dict there as well so my language server will stop yelling at me :)

Thanks!

Footnotes

  1. https://typing.python.org/en/latest/spec/callables.html#annotating-args-and-kwargs

@fscherf

fscherf commented Apr 23, 2026

Copy link
Copy Markdown
Member

Hi @janheini,

Makes sense. Do you need a release for this fix?

Thx for contributing

When annotating kwargs the type annotation refers to the type of the
items within the dict. Drop the encapsulating dict in the type
annotation of Server.reverse.

This is already done correctly in other places around the codebase.

Signed-off-by: Jan Heinemeyer <j.heinemeyer@pengutronix.de>
@fscherf fscherf force-pushed the fix-reverse-type-annotation branch from 73b571b to c4bab32 Compare April 23, 2026 17:29
@codecov-commenter

codecov-commenter commented Apr 23, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.23%. Comparing base (0ff6921) to head (c4bab32).
⚠️ Report is 90 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
+ Coverage   73.12%   73.23%   +0.11%     
==========================================
  Files          88       88              
  Lines        6128     6128              
  Branches     1328     1328              
==========================================
+ Hits         4481     4488       +7     
+ Misses       1364     1360       -4     
+ Partials      283      280       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fscherf fscherf merged commit bf1de21 into lona-web-org:master Apr 23, 2026
5 checks passed
@janheini

Copy link
Copy Markdown
Contributor Author

Thanks for merging!

Makes sense. Do you need a release for this fix?

Not necessarily. You will probably add a new point release when the Python 3.14 compatibility (#632) is fixed. I'm fine with waiting until then :)

@fscherf

fscherf commented Apr 24, 2026

Copy link
Copy Markdown
Member

@janheini I'm also trying to get @SmithChart open PR into the next release as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants