server: reverse: fix kwargs type annotation#634
Conversation
|
Hi @janheini, Makes sense. Do you need a release for this fix? Thx for contributing |
When annotating kwargs the type annotation refers to the type of the items within the dict. Drop the encapsulating dict in the type annotation of Server.reverse. This is already done correctly in other places around the codebase. Signed-off-by: Jan Heinemeyer <j.heinemeyer@pengutronix.de>
73b571b to
c4bab32
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #634 +/- ##
==========================================
+ Coverage 73.12% 73.23% +0.11%
==========================================
Files 88 88
Lines 6128 6128
Branches 1328 1328
==========================================
+ Hits 4481 4488 +7
+ Misses 1364 1360 -4
+ Partials 283 280 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for merging!
Not necessarily. You will probably add a new point release when the Python 3.14 compatibility (#632) is fixed. I'm fine with waiting until then :) |
|
@janheini I'm also trying to get @SmithChart open PR into the next release as well. |
Hey,
when annotating kwargs the type annotation refers to the type of the items within the dict 1. This is already done correctly around the codebase, except for
Server.reverse.Let's drop the dict there as well so my language server will stop yelling at me :)
Thanks!
Footnotes
https://typing.python.org/en/latest/spec/callables.html#annotating-args-and-kwargs ↩