bdev/nvme: fix GPT examination hang in interrupt mode#65
Merged
derekbit merged 1 commit intoOct 21, 2025
Conversation
|
dead code ? |
Author
Keeping the upstream logics so we don't have to add it back later for longhorn/longhorn#11662. |
derekbit
reviewed
Oct 16, 2025
| * incompatible with interrupt mode polling. | ||
| */ | ||
| if (spdk_interrupt_mode_is_enabled() && g_nvme_trtype != SPDK_NVME_TRANSPORT_TCP) { | ||
| if (spdk_interrupt_mode_is_enabled() && period == 0) { |
Member
There was a problem hiding this comment.
In what situation is the period zero?
Author
There was a problem hiding this comment.
It won’t reach this logic, but keeping it to keep the original upstream logic visible for later.
#65 (comment)
c3y1huang
force-pushed
the
11816-nvme-driver-interrup-mode-support-with-drivers
branch
from
October 21, 2025 02:25
11657de to
b1069f7
Compare
- Remove the dependency on global transport type (g_nvme_trtype). - In interrupt mode, always enable periodic polling so TCP qpairs can process send/receive queues and complete I/O. longhorn/longhorn-11816 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
c3y1huang
force-pushed
the
11816-nvme-driver-interrup-mode-support-with-drivers
branch
from
October 21, 2025 02:29
b1069f7 to
258cf4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#11816
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context