fix(habits): add null check for commit author property#1778
Closed
calilkhalil wants to merge 2 commits intolowlighter:masterfrom
Closed
fix(habits): add null check for commit author property#1778calilkhalil wants to merge 2 commits intolowlighter:masterfrom
calilkhalil wants to merge 2 commits intolowlighter:masterfrom
Conversation
Fixes TypeError when GitHub API returns commits without author data. Some events (from bots, deleted users, or malformed API responses) don't have the author property defined, causing the destructuring to fail with 'Cannot destructure property author of undefined'.
Author
|
Duplicated |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a TypeError that occurs when the GitHub API returns events with commits that don't have an
authorproperty defined.Problem
The habits plugin crashes with the following error:
This happens because some commits returned by the GitHub Events API don't have the
authorproperty (e.g., commits from deleted users, bots, or malformed API responses).Solution
Added a null check before accessing the
authorproperty in the filter callback:Testing
Related Issues
Fixes users experiencing "Cannot destructure property 'author' of 'undefined'" errors when using the habits plugin.