fix(library): restore relationship assessment popovers - #840
Closed
FelixTJDietrich wants to merge 3 commits into
Closed
fix(library): restore relationship assessment popovers#840FelixTJDietrich wants to merge 3 commits into
FelixTJDietrich wants to merge 3 commits into
Conversation
7 tasks
Contributor
Author
|
Superseded by #841, which carries this work plus the rest of the fixes the Artemis integration needs on a single branch off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relationship assessment popovers open again when edge-editing actions are hidden.
Assessment integrations can intentionally make a diagram read-only while still letting instructors double-click nodes and relationships to add feedback. Node feedback continued to work, but relationship feedback silently failed because its positioning anchor disappeared together with the edit toolbar.
Release note
Assess relationships reliably when editing controls are hidden.
Implementation notes
React Flow unmounts an
EdgeToolbarwhen itsisVisibleprop is false. Apollon used that same toolbar as the relationship popover anchor, so hiding delete, edit, and routing controls also removed the anchor required by assessment popovers.This change keeps React Flow's positioning host mounted as a non-interactive anchor and conditionally renders only the editing actions. The anchor lifecycle is therefore independent of toolbar visibility, without adding host-specific DOM handling or changing Apollon's public API.
A focused regression test verifies both sides of the contract: the anchor remains mounted while editing buttons remain absent. A patch changeset is included.
Steps for testing
Automated validation:
pnpm lint(green; existing warnings only)pnpm format:checkpnpm buildpnpm test(89 files, 1,782 passed, 1 skipped)Screenshots / screencasts
Not applicable: this restores an existing transient popover interaction without changing its visual design. The interaction and hidden-toolbar state are covered by automated tests.
Checklist
pnpm lint && pnpm format:check && pnpm build && pnpm testlocally — green