Skip to content

Commit 0fedeb6

Browse files
author
Markus Paulsen
committed
fix: update the pointcut comparison tool for the renamed maps
The checkstyle rename of the public pointcut maps to upper snake case broke tools/pointcut_comparison.R, which extracts each map from the instrumentation source with a regex built from the field name. Its five hard-coded names still used the old camel case, so after the rename the patterns matched nothing and the tool silently produced empty results. Updated the names to match the source; the tool runs again and extracts the maps as before.
1 parent fe41355 commit 0fedeb6

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

tools/pointcut_comparison.R

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,11 @@ parse_instrumentation <- function(filepath) {
5454

5555
# Define which maps to extract and their actions
5656
maps <- list(
57-
list(name = "methodsWhichCanReadFiles", action = "READ"),
58-
list(name = "methodsWhichCanOverwriteFiles", action = "OVERWRITE"),
59-
list(name = "methodsWhichCanExecuteFiles", action = "EXECUTE"),
60-
list(name = "methodsWhichCanDeleteFiles", action = "DELETE"),
61-
list(name = "methodsWhichCanCreateFiles", action = "CREATE")
57+
list(name = "METHODS_WHICH_CAN_READ_FILES", action = "READ"),
58+
list(name = "METHODS_WHICH_CAN_OVERWRITE_FILES", action = "OVERWRITE"),
59+
list(name = "METHODS_WHICH_CAN_EXECUTE_FILES", action = "EXECUTE"),
60+
list(name = "METHODS_WHICH_CAN_DELETE_FILES", action = "DELETE"),
61+
list(name = "METHODS_WHICH_CAN_CREATE_FILES", action = "CREATE")
6262
)
6363

6464
results <- data.frame(

0 commit comments

Comments
 (0)