Skip to content

Feature/assessment/improve presentation UI - #13514

Draft
jsuckart wants to merge 56 commits into
developfrom
feature/assessment/improve-presentation-ui
Draft

Feature/assessment/improve presentation UI#13514
jsuckart wants to merge 56 commits into
developfrom
feature/assessment/improve-presentation-ui

Conversation

@jsuckart

@jsuckart jsuckart commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR is the second iteration of introducing presentation assessments to artemis. It reworks the database structure to support different grading instances for each presentation and improves the UI. Additionally it adds a feature toggle for the feature.

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
  • I strictly followed the principle of data economy for all database calls.
  • I strictly followed the server coding and design guidelines and the REST API guidelines.
  • I added multiple integration tests (Spring) related to the features (with a high test coverage).
  • I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
  • I strictly followed the principle of data economy for all client-server REST calls.
  • I strictly followed the client coding guidelines.
  • I strictly followed the AET UI-UX guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple integration tests (Vitest) related to the features (with a high test coverage), while following the test guidelines.
  • I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

This PR adds the basis for presentation assessment.
This is intended as a minimal first iteration that establishes the backend domain, REST API, a prototype UI and a feature toggle, while keeping the implementation scoped and independent from the existing exercise assessment flow.

Description

The PR adds:

  • A new presentation server package with domain, DTO, repository, service, and resource classes.
  • A new presentation_assessment database table for course-level presentation assessments.
  • A join table for assigning students to presentation assessments.
  • REST endpoints under /api/courses/{courseId}/presentation-assessments.
  • A new course setting presentationAssessmentsEnabled
  • A Presentations sidebar entry below Lectures, only visible to instructors when enabled for the course.
  • A presentation management UI with create/edit modal dialogs.
  • Student assignment within the create/edit presentation modal.
  • English and German translations for the new UI strings.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 2 Students
  • 1 Course where the instructor has instructor permissions
  1. Log in as an instructor.
  2. Navigate to Course Administration.
  3. Open the course settings.
  4. Verify that the Presentations Enabled toggle is disabled by default.
  5. Enable the toggle and save the course settings.
  6. Verify that the Presentations entry appears in the course sidebar below Lectures.
  7. Open Presentations.
  8. Click Create presentation.
  9. Enter a title, max points, optional result points, date, and description.
  10. Add one or more students to the presentation.
  11. Save the presentation.
  12. Verify that the presentation appears in the table.
  13. Edit the presentation and verify that the modal opens with the existing values and assigned students.
  14. Change values and save.
  15. Verify that the table reflects the updated presentation.
  16. Delete the presentation and verify that it is removed from the table.
  17. Go back to course settings, disable Presentations Enabled, save, and verify that the sidebar entry disappears.

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

Note: Some tests in the Test job did not pass (failure). Coverage below may be partial.

Client

Coverage data not found. Run tests first or check if coverage-summary.json exists.

Server

Class/File Line Coverage Lines
DatabaseConfiguration.java not found (modified) 24
Feature.java not found (modified) 5
Course.java not found (modified) 713
CourseCreateDTO.java not found (modified) 66
CourseUpdateDTO.java not found (modified) 90
ExerciseRepository.java not found (modified) 623
PresentationAssessment.java not found (modified) 98
PresentationAssessmentInstance.java not found (modified) 95
PresentationAssessmentMode.java not found (modified) 4
PresentationAssessmentDTO.java not found (modified) 28
PresentationAssessmentInstanceDTO.java not found (modified) 16
PresentationAssessmentStudentDTO.java not found (modified) 11
PresentationAssessmentInstanceRepository.java not found (modified) 16
PresentationAssessmentRepository.java not found (modified) 40
PresentationAssessmentService.java not found (modified) 152
PresentationAssessmentResource.java not found (modified) 137

Last updated: 2026-08-24 12:33:33 UTC

Screenshots

jsuckart and others added 30 commits July 10, 2026 19:05
…/introduce-presentation-assessment

# Conflicts:
#	src/main/java/de/tum/cit/aet/artemis/course/dto/CourseCreateDTO.java
#	src/main/java/de/tum/cit/aet/artemis/course/dto/CourseUpdateDTO.java
…/introduce-presentation-assessment

# Conflicts:
#	src/main/java/de/tum/cit/aet/artemis/course/dto/CourseUpdateDTO.java
#	src/main/java/de/tum/cit/aet/artemis/course/service/CourseAccessService.java
#	src/main/webapp/app/course/manage/update/course-update.component.ts
#	src/test/java/de/tum/cit/aet/artemis/core/util/CourseTestService.java
…sentation-assessment' into feature/assessment/introduce-presentation-assessment
…/introduce-presentation-assessment

# Conflicts:
#	src/main/webapp/app/course/manage/course-management-container/course-management-container.component.ts
…sentation-assessment' into feature/assessment/introduce-presentation-assessment
@github-project-automation github-project-automation Bot moved this to Work In Progress in Artemis Development Aug 16, 2026
@github-actions github-actions Bot added tests server Pull requests that update Java code. (Added Automatically!) client Pull requests that update TypeScript code. (Added Automatically!) database Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment. core Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module course labels Aug 16, 2026
…nto feature/assessment/improve-presentation-ui

# Conflicts:
#	src/main/java/de/tum/cit/aet/artemis/presentation/service/PresentationAssessmentService.java
#	src/main/java/de/tum/cit/aet/artemis/presentation/web/PresentationAssessmentResource.java
#	src/main/webapp/app/course/shared/course-group/course-group.component.ts
#	src/main/webapp/app/presentation/manage/presentation-assessment-feature.guard.ts
#	src/main/webapp/app/presentation/manage/presentation-assessment-form-dialog.component.html
#	src/main/webapp/app/presentation/manage/presentation-assessment-form-dialog.component.spec.ts
#	src/main/webapp/app/presentation/manage/presentation-assessment-form-dialog.component.ts
#	src/main/webapp/app/presentation/manage/presentation-assessment-management.component.html
#	src/main/webapp/app/presentation/manage/presentation-assessment-management.component.spec.ts
#	src/main/webapp/app/presentation/manage/presentation-assessment-management.component.ts
#	src/main/webapp/app/presentation/manage/presentation-assessment.service.spec.ts
#	src/main/webapp/app/presentation/manage/presentation-assessment.service.ts
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

End-to-End Test Results

Phase Status Details
All Tests ✅ Passed
TestsPassed ✅Skipped ⚠️FailedTime ⏱
All E2E Tests Report (PR)372 ran365 passed7 skipped0 failed45m 46s

Test Strategy: Running all tests (configuration or infrastructure changes detected)

Overall: ✅ E2E tests passed

🔗 Workflow Run · 📊 Test Report

@jsuckart
jsuckart temporarily deployed to playwright-e2e-tests August 24, 2026 12:30 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

admin client Pull requests that update TypeScript code. (Added Automatically!) core Pull requests that affect the corresponding module course database Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment. exercise Pull requests that affect the corresponding module server Pull requests that update Java code. (Added Automatically!) tests

Projects

Status: Work In Progress

Development

Successfully merging this pull request may close these issues.

1 participant