Development: Drop the unused result and build log order columns - #13571
Draft
krusche wants to merge 2 commits into
Draft
Development: Drop the unused result and build log order columns#13571krusche wants to merge 2 commits into
Development: Drop the unused result and build log order columns#13571krusche wants to merge 2 commits into
Conversation
krusche
temporarily deployed
to
playwright-e2e-tests
August 25, 2026 18:47 — with
GitHub Actions
Inactive
End-to-End Test Results
❌ Failed Tests
Test Strategy: Running all tests (configuration or infrastructure changes detected) Overall: ❌ E2E: real (non-flaky) test failure 🔗 Workflow Run · 📊 Test Report |
krusche
force-pushed
the
chore/programming/drop-unused-order-columns
branch
from
August 25, 2026 21:43
9ded330 to
e3fa125
Compare
krusche
had a problem deploying
to
playwright-e2e-tests
August 25, 2026 22:06 — with
GitHub Actions
Error
krusche
force-pushed
the
chore/programming/drop-unused-order-columns
branch
from
August 25, 2026 22:20
e3fa125 to
55bc326
Compare
krusche
had a problem deploying
to
playwright-e2e-tests
August 25, 2026 22:27 — with
GitHub Actions
Error
result.results_order and build_log_entry.build_log_entries_order no longer have a reader. The correction round moved onto the result and the build log entries are ordered by the timestamp they already carry, so neither column is mapped. They were deliberately kept at the time so that rolling the application back would still work. This drops them one release later, guarded by a column-exists precondition so it is idempotent.
krusche
force-pushed
the
chore/programming/drop-unused-order-columns
branch
from
August 25, 2026 23:15
55bc326 to
c1aff01
Compare
krusche
temporarily deployed
to
playwright-e2e-tests
August 25, 2026 23:24 — with
GitHub Actions
Inactive
…to chore/programming/drop-unused-order-columns
krusche
temporarily deployed
to
playwright-e2e-tests
August 26, 2026 07:40 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops
result.results_orderandbuild_log_entry.build_log_entries_order. Neither column has a reader any more: the correction round moved onto the result and the build log entries are ordered by the timestamp they already carry.Important
Do not merge before the release that contains #13570 has shipped. That PR stopped using both columns but deliberately left them in the database, so that rolling the application back to the previous version would still work. Dropping them in the same release would take that away. This is a draft until then.
It is also stacked on
feature/programming/minimize-result-processing-data, so the base has to be switched todeveloponce #13570 is merged.Motivation and Context
Follow-up cleanup for #13570. Both columns existed to let Hibernate maintain the position of an entry inside an
@OrderColumncollection. Maintaining that position is what forced every write in those areas to go through a save of the whole submission, and saving a submission selects it together with its participation, its exercise and the exercise's course, because all three associations are eager. That is where most of the ~140 KB per build result came from.Now that the position is not needed, the columns are only occupying space and inviting someone to rely on them again.
Description
One changelog with two changesets, each guarded by a
columnExistsprecondition withonFail="MARK_RAN", so the migration is idempotent and does not fail on a database where the column is already gone.No code changes: neither column is mapped or referenced anywhere.
Steps for Testing
Prerequisites:
Development: Minimize data transfer when processing a build result #13570. The migration applies without error.Server Tests
762 server tests were run locally with both columns dropped, across the result-processing, assessment, submission-policy, localci and participation suites. Since the test schema is built by Liquibase, this exercises the drop itself: if anything still expected either column, these would fail.
Review Progress
Code Review
Checklist
General
Server
Changes affecting Programming Exercises