fix(ci): package reactor dependencies before server tests - #1585
Merged
Conversation
Contributor
|
Warning Review limit reachedNext included review available in 25 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
bug
Contributor
🧩 Storybook Preview
|
Contributor
📚 Documentation Preview
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make server test runs finish the Maven reactor at the
packagephase so a cachedgenerated-clientsmodule always exposes a JAR to the downstream application. This fixes the current main and branch failures where Maven restored the upstream module from build cache, then tried—and failed—to download the repository-local artifact from Maven Central.This uses Maven's standard lifecycle rather than retries, cache deletion, manual artifact copying, or a mutable local-repository workaround. It matches the failure and supported workaround documented in apache/maven-build-cache-extension#492; the upstream code fix in #493 is not released.
The contributor documentation now points full-reactor test runs at the repository-owned
test:server:*commands, keeping lifecycle details behind a stable project interface. Focused application-only and live-test Maven commands remain documented where they are intentional.No changeset is included because this changes CI and contributor tooling only; it does not change shipped server, webapp, or container behavior.
How to test
bun run verifygenerated-clientsfrom the Maven build cache, resolves it in the application reactor, and completes the server package successfully.Local verification completed successfully, including 7,101 server tests, 992 webapp tests, 168 webapp lint-rule tests, 1,625 Storybook tests, production webapp and Storybook builds, and the documentation build.
Checklist