docs(security): publish the 1.0 threat model - #1617
Merged
Merged
Conversation
Contributor
|
Warning Review limit reachedNext included review available in 35 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (23)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
documentation
Contributor
📚 Documentation Preview
|
github-actions
Bot
added
the
webapp
Contributor
🧩 Storybook Preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Publishes the operator-facing 1.0 threat model for the supported Docker Compose topology. It brings the webhook ingress, LLM sandbox, egress gateway, and SQL-layer tenancy boundaries into one reviewable document, with attacker assumptions, a data-flow diagram, enforcement links, tests, and residual risks.
Regenerating the API contract in CI also exposed stale generated TypeScript import specifiers left by the current generator; the generated client is refreshed without changing the API schema.
The review also exposed an unsafe operational default: detected SQL tenancy violations previously logged and continued. This PR changes the default to fail closed (
throw);logandoffremain explicit diagnostic overrides. The document is deliberately candid about defense limits, including the SQL inspector not being an authorization mechanism, the application server remaining reachable from the sandbox job network, and DNS rebinding protection depending on each integration client.Fixes #1603
How to test
bun run formatbun run checknode scripts/run-mvnw.ts -f application/pom.xml -Dtest=TenancyEnforcementPropertiesTest testbun run --cwd docs buildbun run verify(all change-related gates passed; the unrelated Storybook suite was flaky locally—one run ended with dynamic-import fetch failures, and a retry reached 1,632 passing stories before an existingAddChannelDialogvisibility assertion failed)For a manual documentation smoke test:
bun run --cwd docs serve./Hephaestus/admin/threat-model.Checklist