Skip to content

Usability: Fix keyboard navigation in application carousel - #2027

Merged
az108 merged 11 commits into
mainfrom
bugfix/fix-keyboard-navigation-in-application-carousel
Mar 8, 2026
Merged

Usability: Fix keyboard navigation in application carousel#2027
az108 merged 11 commits into
mainfrom
bugfix/fix-keyboard-navigation-in-application-carousel

Conversation

@Cathy0123456789

@Cathy0123456789 Cathy0123456789 commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Checklist

General

Client

Motivation and Context

Closes #2026

Description

This pull request improves keyboard navigation in the ApplicationCarouselComponent by ensuring arrow key navigation does not interfere with user input in editable elements or when modifier keys are pressed. It also adds comprehensive tests to verify these behaviors.

Steps for Testing

Prerequisites:

  1. Log in to TUMApply as professor
  2. Go to Recruitment - Review
  3. At the bottom, enter something in the comment field
  4. Navigate with the left and right arrow on your keyboard, see that it navigates the cursor and applications don't switch

Review Progress

Code Review

  • Code Review 1

Manual Tests

  • Test 1

Test Coverage

Warning: Client tests failed. Coverage could not be fully measured. Please check the workflow logs.

Last updated: 2026-03-08 14:42:38 UTC

… focus is inside input, textarea, or contenteditable elements
@github-actions

github-actions Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

@Cathy0123456789 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions github-actions Bot added client Pull requests that update TypeScript code. (Added Automatically!) tests labels Mar 7, 2026
@github-actions

github-actions Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

@Cathy0123456789
Cathy0123456789 marked this pull request as draft March 7, 2026 17:54
@github-actions

github-actions Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

@github-actions

github-actions Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

@Cathy0123456789 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions

github-actions Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

@Cathy0123456789 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions

github-actions Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

@github-actions

github-actions Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

@Cathy0123456789 Test coverage has been automatically updated in the PR description.

@github-actions

github-actions Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

@github-actions

github-actions Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

@Cathy0123456789 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions

github-actions Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

@Cathy0123456789 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions

github-actions Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

@Cathy0123456789 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions

github-actions Bot commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

@Cathy0123456789 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@Cathy0123456789
Cathy0123456789 marked this pull request as ready for review March 8, 2026 14:41
@github-actions

github-actions Bot commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

@Cathy0123456789 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@az108
az108 merged commit b4a8342 into main Mar 8, 2026
26 checks passed
@az108
az108 deleted the bugfix/fix-keyboard-navigation-in-application-carousel branch March 8, 2026 15:53
@Cathy0123456789 Cathy0123456789 added the evaluation Code changes in evaluation module. label Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Pull requests that update TypeScript code. (Added Automatically!) evaluation Code changes in evaluation module. ready for review tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent carousel navigation in editable fields and with modifier keys

2 participants