Bugfix: Send support and notification emails to the new DocApply mailboxes - #2632
Merged
Conversation
…ilboxes Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Cathy0123456789
approved these changes
Aug 9, 2026
Cathy0123456789
left a comment
Contributor
There was a problem hiding this comment.
Code LGTM and tested locally except for outgoing emails since not possible locally, everything works 👍🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Client
Motivation and Context
With the rename from TUMApply to DocApply, the AET mailboxes were renamed as well. The new addresses are
docapply.aet@xcit.tum.deandsupport-docapply.aet@xcit.tum.de.The rename PR (#2627) rewrote the addresses mechanically along with the rest of the
tum-apply→doc-applyreplacements, which produceddoc-apply.aet@xcit.tum.deandsupport-doc-apply.aet@xcit.tum.de. Those hyphenated addresses are not real mailboxes, so onmaintoday:Description
Replaced the hyphenated placeholder with the actual mailbox names. No behaviour, structure, or configuration keys changed — only the default address values and the user-facing text.
Server:
application.yml: default ofaet.email.from(AET_EMAIL_FROM) is nowdocapply.aet@xcit.tum.de.ResearchGroupService:@Valuefallback foraet.contact-emailis nowdocapply.aet@xcit.tum.de.nginx/maintenance.html: support link and label now point tosupport-docapply.aet@xcit.tum.de.Client:
i18n/en/about-us.json,i18n/de/about-us.json: support mailbox address.i18n/en/privacy.json,i18n/de/privacy.json: contact address in the data rights paragraph.The deployed environments set
AET_EMAIL_FROMandaet.contact-emailexplicitly, so this only corrects the checked-in defaults — but those defaults are what local and test runs fall back to.Steps for Testing
Prerequisites:
Checks:
support-docapply.aet@xcit.tum.deand themailto:link opens the same address. Switch the language to German and confirm the same.support-docapply.aet@xcit.tum.de, in both English and German.src/main/resources/config/nginx/maintenance.htmlin a browser and confirm the support link points tosupport-docapply.aet@xcit.tum.de.AET_EMAIL_FROMset, trigger any outgoing mail (e.g. a research group invitation) and confirm the sender isdocapply.aet@xcit.tum.de.git grep -n "doc-apply\.aet@"returns nothing.Review Progress
Code Review
Manual Tests