Skip to content

Bugfix: Send support and notification emails to the new DocApply mailboxes - #2632

Merged
az108 merged 1 commit into
mainfrom
general/update-contact-email-addresses
Aug 9, 2026
Merged

Bugfix: Send support and notification emails to the new DocApply mailboxes#2632
az108 merged 1 commit into
mainfrom
general/update-contact-email-addresses

Conversation

@az108

@az108 az108 commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Checklist

General

Server

Client

Motivation and Context

With the rename from TUMApply to DocApply, the AET mailboxes were renamed as well. The new addresses are docapply.aet@xcit.tum.de and support-docapply.aet@xcit.tum.de.

The rename PR (#2627) rewrote the addresses mechanically along with the rest of the tum-applydoc-apply replacements, which produced doc-apply.aet@xcit.tum.de and support-doc-apply.aet@xcit.tum.de. Those hyphenated addresses are not real mailboxes, so on main today:

  • outgoing notification mails default to a sender address that does not exist,
  • the support address shown to users on the About Us page, the Privacy page, and the nginx maintenance page is a dead address,
  • the fallback support address used in research group invitation mails is a dead address.

Description

Replaced the hyphenated placeholder with the actual mailbox names. No behaviour, structure, or configuration keys changed — only the default address values and the user-facing text.

Server:

  • application.yml: default of aet.email.from (AET_EMAIL_FROM) is now docapply.aet@xcit.tum.de.
  • ResearchGroupService: @Value fallback for aet.contact-email is now docapply.aet@xcit.tum.de.
  • nginx/maintenance.html: support link and label now point to support-docapply.aet@xcit.tum.de.

Client:

  • i18n/en/about-us.json, i18n/de/about-us.json: support mailbox address.
  • i18n/en/privacy.json, i18n/de/privacy.json: contact address in the data rights paragraph.

The deployed environments set AET_EMAIL_FROM and aet.contact-email explicitly, so this only corrects the checked-in defaults — but those defaults are what local and test runs fall back to.

Steps for Testing

Prerequisites:

  1. Log in to DocApply

Checks:

  1. Open About Us and confirm the support mailbox reads support-docapply.aet@xcit.tum.de and the mailto: link opens the same address. Switch the language to German and confirm the same.
  2. Open Privacy and confirm the contact address in the "Rights to rectification, erasure, and restriction" section reads support-docapply.aet@xcit.tum.de, in both English and German.
  3. Open src/main/resources/config/nginx/maintenance.html in a browser and confirm the support link points to support-docapply.aet@xcit.tum.de.
  4. With no AET_EMAIL_FROM set, trigger any outgoing mail (e.g. a research group invitation) and confirm the sender is docapply.aet@xcit.tum.de.
  5. Confirm no hyphenated address remains: git grep -n "doc-apply\.aet@" returns nothing.

Review Progress

Code Review

  • Code Review 1

Manual Tests

  • Test 1

…ilboxes

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added server Pull requests that update Java code. (Added Automatically!) client Pull requests that update TypeScript code. (Added Automatically!) user management Code changes in user management module. config-change labels Aug 5, 2026
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@Cathy0123456789 Cathy0123456789 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and tested locally except for outgoing emails since not possible locally, everything works 👍🏼

@az108
az108 merged commit 0a72d68 into main Aug 9, 2026
18 checks passed
@az108
az108 deleted the general/update-contact-email-addresses branch August 9, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Pull requests that update TypeScript code. (Added Automatically!) config-change server Pull requests that update Java code. (Added Automatically!) user management Code changes in user management module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants