Update subcore.py#35
Open
harmeetsingh-work wants to merge 1 commit into
Open
Conversation
Making it compatible with apple silicon.
ltdrdata
reviewed
Mar 2, 2025
ltdrdata
left a comment
Owner
There was a problem hiding this comment.
The patch affects not only the functionality used in subpack but also impacts all instances of torch.load across ComfyUI.
It seems appropriate to conditionally call with map_location only when it is silicon.
Author
|
@ltdrdata the code change: It loads 'mps' if mps(apple silicon) is available else 'cuda' if cuda is available else it will use 'cpu'. |
Owner
If it is not MPS, no device should be applied. It should be determined by the callsite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making it compatible with apple silicon.