fix(compiler): set DuckDB temp_directory so spills don't depend on a writable cwd - #41
Merged
Merged
Conversation
…writable cwd In-memory DuckDB defaulted its disk-spill dir to ./.tmp relative to the process cwd. When a query spilled and the cwd wasn't writable (Docker WORKDIR /app is root-owned, runtime runs as node), it failed with "IO Error: Failed to create directory .tmp". Route every in-memory instance through createInMemoryDuckDB(), which sets a writable temp_directory under os.tmpdir().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In-memory DuckDB defaulted its disk-spill directory to `./.tmp` relative to the process cwd because `temp_directory` was never set. The moment a query spilled to disk and the cwd wasn't writable, it failed with:
```
IO Error: Failed to create directory ".tmp": Permission denied
```
This bit the Docker image: `WORKDIR /app` is root-owned, the runtime runs as `node`, and `serve` validates every app at boot — so a dataset whose query spilled to disk crashed boot validation and the whole workspace refused to serve. Version-independent and latent; it surfaced once agent-edited data grew large enough to spill.
Fix
Added `createInMemoryDuckDB()` in `packages/compiler/src/writers.ts` that passes a writable `temp_directory` under `os.tmpdir()`, and routed all five `DuckDBInstance.create(":memory:")` call sites (engine builder + inspect/infer paths + writers) through it.
Test
`pnpm build && pnpm typecheck && pnpm test && pnpm lint` all pass (392 tests).