Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…plates Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…r Controls interactivity Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Storybook deployed with Cloudflare Pages ☁️ 📖 🚀Storybook
Built from commit 24dd22c |
richtera
approved these changes
Apr 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new lukso-timeline web component to the design system package, including Storybook documentation and package exports so it can be consumed from the published build.
Changes:
- Introduces
lukso-timelinecomponent implementation and Tailwind-based styling. - Adds Storybook stories demonstrating multiple timeline states (before start, in range, after end, forever).
- Exposes the new component via the library barrel export and
package.jsonexports (and bumps package version).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/lukso-timeline/style.css | Defines base host styling for the new component. |
| src/components/lukso-timeline/lukso-timeline.stories.ts | Adds Storybook examples for the component’s various states. |
| src/components/lukso-timeline/index.ts | Implements the timeline rendering, date parsing, formatting, and progress computation. |
| src/components/index.ts | Re-exports the new component from the components barrel. |
| package/package.json | Bumps version and adds exports entries for the new component build outputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dzbo
requested changes
Apr 17, 2026
Collaborator
There was a problem hiding this comment.
Few things need improvement:
- When start date is today we need to display like this, note short left side and "Now" word
- Arrows are not in color of line
-
"Today After End" doesn't exist, we don't show timeline after the end date
-
Before event start we show solid line not the one in progress
- On design this arrow is shorter, let's remove "-" under label it doesn't do anything
- Any time we are in progres (green bar appears) we show grey bar in progress too
- Peter forgot to add this but when we are within range we show "Today" above line
- The in progress line color looks odd, should be matching with solid line
Contributor
Author
|
dzbo
requested changes
Apr 20, 2026
Collaborator
dzbo
left a comment
dzbo
left a comment
There was a problem hiding this comment.
- The missing dot
- Progress style
dzbo
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ID
https://app.clickup.com/t/2645698/DEV-16169