Skip to content

Fix undocumented behavior in deepxde.nn.activations.get(identifier) #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
echen5503 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix undocumented behavior in deepxde.nn.activations.get(identifier) #2060

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8715274
Fix undocumented behavior in deepxde.nn.activations.get(identifier)
echen5503 Feb 27, 2026
323bb36
Fix capitalization of 'linear' in docstring
echen5503 Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions deepxde/nn/activations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ def get(identifier):

Args:
identifier: Function or string (ELU, GELU, ReLU, SELU, Sigmoid, SiLU, sin,
Swish, tanh).
Swish, tanh, linear).

Returns:
Function corresponding to the input string or input function.
Function corresponding to the input string or input function, Linear if identifier is None.
Copy link
Copy Markdown

@SimingShan SimingShan Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Linear" -> "linear"

"""
if identifier is None:
return linear
Expand All @@ -62,6 +62,7 @@ def get(identifier):
"sin": bkd.sin,
"swish": bkd.silu,
"tanh": bkd.tanh,
"linear": linear,
}[identifier.lower()]
if callable(identifier):
return identifier
Expand Down