Fix indexing in data sampling for training labels#2068
Open
Konat23 wants to merge 1 commit intolululxvi:masterfrom
Open
Fix indexing in data sampling for training labels#2068Konat23 wants to merge 1 commit intolululxvi:masterfrom
Konat23 wants to merge 1 commit intolululxvi:masterfrom
Conversation
Contributor
|
Can you provide code that demonstrates this issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed an issue in TripleCartesianProd.train_next_batch when using tuple batch_size (i.e., separate batch sizes for branch and trunk inputs).
Currently, the code uses:
self.train_y[indices_branch, indices_trunk]However, this performs NumPy advanced indexing over paired indices instead of selecting the Cartesian product. As a result, it returns a 1D array of shape
(batch_size,)instead of the expected 2D submatrix(len(indices_branch), len(indices_trunk)).Since
TripleCartesianProdrepresents data in Cartesian product form (y_trainwith shape(N1, N2)), the batch selection should also preserve this structurWhy this matters
This affects training when using:
batch_size = (branch_batch_size, trunk_batch_size)and may lead to: