Skip to content

Fixed deprecated layershell code#457

Open
stefonarch wants to merge 2 commits intomasterfrom
silence_warning
Open

Fixed deprecated layershell code#457
stefonarch wants to merge 2 commits intomasterfrom
silence_warning

Conversation

@stefonarch
Copy link
Copy Markdown
Member

@stefonarch stefonarch commented Mar 17, 2026

No description provided.

@isf63 isf63 mentioned this pull request Mar 21, 2026
Draft
@stefonarch stefonarch marked this pull request as draft March 27, 2026 08:21
@stefonarch stefonarch changed the title Fixed deprecated layereshell code Fixed deprecated layershell code Apr 20, 2026
@stefonarch stefonarch marked this pull request as ready for review April 20, 2026 12:39
tsujan
tsujan reviewed Apr 21, 2026
View reviewed changes
Comment thread src/notificationarea.cpp
tsujan
tsujan reviewed Apr 21, 2026
View reviewed changes
Comment thread src/notificationarea.cpp Outdated
@tsujan
Copy link
Copy Markdown
Member

tsujan commented Apr 21, 2026

We should first make sure that layer-shell-qt-6.6.X has come into the oldest distro that the latest LXQt supports. Otherwise, a harmless compilation warning isn't important for now.

@stefonarch
Copy link
Copy Markdown
Member Author

stefonarch commented Apr 21, 2026

Here's the list:
https://repology.org/project/layer-shell-qt/versions

Debian stable won't have it afaik.

@stefonarch
Copy link
Copy Markdown
Member Author

stefonarch commented Apr 22, 2026

Was my fault, should be good by now.

Not sure if we should ship this in git or even with 2.5 as it will exclude debian stable.
I tried today compiling LXQt 2.4 on debian testing: impossible as there is a mix of Qt 6.8.2 and 6.10.2 at the moment.

tsujan
tsujan approved these changes Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@tsujan tsujan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM now.

Not sure if we should ship this in git or even with 2.5 as it will exclude debian stable.

There's no haste; we can keep this as an approved PR for now, without merging it. But if some future version of layer-shell-qt removes that compatibility function, we'll have to merge it and exclude Debian Stable.

@stefonarch stefonarch moved this to Bugs fixed in LXQt 2.5 Release Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsujan tsujan tsujan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

LXQt 2.5 Release
Status: Bugs and warnings fixed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stefonarch @tsujan