feat: import dispatch.yaml from mlab-ns and deploy it via cloudbuild#255
Open
robertodauria wants to merge 2 commits intomainfrom
Open
feat: import dispatch.yaml from mlab-ns and deploy it via cloudbuild#255robertodauria wants to merge 2 commits intomainfrom
robertodauria wants to merge 2 commits intomainfrom
Conversation
Pull Request Test Coverage Report for Build 22676117205Details
💛 - Coveralls |
bassosimone
requested changes
Mar 5, 2026
Member
bassosimone
left a comment
There was a problem hiding this comment.
I think we should also deploy dispatch.yaml for mlab-sandbox and mlab-staging in the cloudbuild.yaml file, not just for mlab-ns. Otherwise we're not fully replicating what m-lab/mlab-ns's cloudbuild.yaml used to do. It deployed dispatch.yaml to all three projects (PROJECT_IN=mlab-sandbox,mlab-staging,mlab-ns - see https://github.com/m-lab/mlab-ns/blob/v2023.02.13/cloudbuild.yaml#L29).
bassosimone
requested changes
Mar 12, 2026
Member
bassosimone
left a comment
There was a problem hiding this comment.
Also, it seems we are not ready yet to deploy this beyond staging. This merge request should be stalled until we have further operational clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is