Conversation
|
馃摝 Opteryx build version: |
|
馃摝 Opteryx build version: |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request vendors the fast_float library (#2722) by adding the complete fast_float C++ library to the third_party directory. The library provides fast floating-point number parsing capabilities.
- Adds the entire fast_float v8.0.2 library to the third_party directory
- Includes comprehensive floating-point parsing functionality with support for multiple formats
- Provides templates for various floating-point types including C++23 float16/float32/float64/bfloat16 types
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| third_party/fastfloat/fast_float/parse_number.h | Main parsing functions and logic for converting strings to floating-point numbers |
| third_party/fastfloat/fast_float/float_common.h | Common type definitions, platform detection, and utility functions |
| third_party/fastfloat/fast_float/fast_table.h | Lookup tables for powers of five used in decimal to binary conversion |
| third_party/fastfloat/fast_float/fast_float.h | Main header file with public API declarations |
| third_party/fastfloat/fast_float/digit_comparison.h | Digit comparison algorithms for precise floating-point conversion |
| third_party/fastfloat/fast_float/decimal_to_binary.h | Core algorithms for converting decimal representations to binary |
| third_party/fastfloat/fast_float/constexpr_feature_detect.h | Feature detection macros for C++ version and compiler capabilities |
| third_party/fastfloat/fast_float/bigint.h | Big integer implementation for high-precision arithmetic |
| /** | ||
| * Special case +inf, -inf, nan, infinity, -infinity. | ||
| * The case comparisons could be made much faster given that we know that the | ||
| * strings a null-free and fixed. |
There was a problem hiding this comment.
There's a grammatical error. The text should read 'strings are null-free and fixed' instead of 'strings a null-free and fixed'.
Suggested change
| * strings a null-free and fixed. | |
| * strings are null-free and fixed. |
|
馃摝 Opteryx build version: |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request!
We appreciate your contribution to Opteryx. Your time and effort make a difference, and we鈥檙e excited to review your changes. To help ensure a smooth review process, please check the following:
Checklist for a Successful PR
Fixes: #2722
Please replace
<issue_number_goes_here>with the corresponding issue number.Thank you for contributing to Opteryx! 馃帀