Skip to content

go ports: fetch renamed vendors from their current repo - #34580

Open
jrjsmrtn wants to merge 1 commit into
macports:masterfrom
jrjsmrtn:fix-smartystreets-assertions
Open

go ports: fetch renamed vendors from their current repo#34580
jrjsmrtn wants to merge 1 commit into
macports:masterfrom
jrjsmrtn:fix-smartystreets-assertions

Conversation

@jrjsmrtn

@jrjsmrtn jrjsmrtn commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Description

Six vendored projects moved to a new GitHub owner: smartystreets/assertions
smarty, imdario/mergodarccio, jtolds/glsjtolio, hajimehoshi/oto
ebitengine, zyedidia/micromicro-editor, go-survey/surveyAlecAivazis.
GitHub embeds the repository name in the tarball's top-level directory, so the bytes
changed while the commit did not.

Updating the checksums alone is wrong for some of these: distfiles.macports.org
still serves the pre-rename tarball for imdario-mergo-* and jtolds-gls-* but the
post-rename one for smartystreets-assertions-*, so a recorded value can match the
mirror or upstream but not both. That is why these fail only when the mirror is
missed. Naming the current repo gives the distfile a name no stale copy answers to.

Found by resolving all 1040 GitHub repos vendored by go ports through the API. Ports
whose vendors are also stale but which fail to build for unrelated reasons are left
out: mos, mos-devel, leaf, gomodctl and kubeval pin a golang.org/x/sys
that no longer compiles, and please fails in gopsutil's cgo.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 26.6.2 25G83 arm64
Xcode 26.6 17F113

Verification

Have you

sudo port destroot passes for all seven after port clean --dist, which is the cold
state CI fetches in. Each extracted tarball was diffed against a checkout of its
pinned ref and is identical, so only the packaging changed. Three remaining port lint warnings are pre-existing and identical on master. Trace mode is unavailable on
this arm64 machine, so -vs rather than -vst. Patch written with AI assistance; I
can explain and defend every line.

@macportsbot

Copy link
Copy Markdown

Notifying maintainers:
@harens for port mos-devel, mos.
@amake for port ec2-ls-hosts.
@herbygillot for port gig, gomodctl, chaakoo, kubeval, leaf.

@mohd-akram

Copy link
Copy Markdown
Member

How is it that distfiles.macports.org serves the new tarball? Also, repo github.com/smarty/assertions needs to be added.

@jrjsmrtn
jrjsmrtn force-pushed the fix-smartystreets-assertions branch from e062587 to 7a36674 Compare September 9, 2026 17:28
@jrjsmrtn jrjsmrtn changed the title go ports: update smartystreets/assertions checksums go ports: fetch renamed vendors from their current repo Sep 9, 2026
Six vendored projects moved to a new GitHub owner. GitHub embeds the
repository name in the top-level directory of the tarball it generates,
so the bytes changed while the commit did not.

Updating the checksums alone is not enough, and for some entries is
wrong: distfiles.macports.org still holds the pre-rename tarball under
some of these names and the post-rename one under others, so a recorded
value can match the mirror or upstream but not both. Naming the current
repo gives the distfile a name no stale copy answers to.

Each extracted tarball was compared against a checkout of its pinned
ref; all are identical, so only the packaging changed.

Closes: https://trac.macports.org/ticket/73098
@jrjsmrtn
jrjsmrtn force-pushed the fix-smartystreets-assertions branch from 7a36674 to fb80f39 Compare September 9, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

6 participants