CI: run tests in parallel with lint (remove needs: lint)#252
Open
NWelde wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
testsjob declaresneeds: lint, which makes the entire test matrixwait for RuboCop and — more importantly — be skipped entirely whenever
RuboCop reports any offense. Since each test job does its own checkout, gem
install, and Postgres service, it doesn't consume anything
lintproduces. ThisPR removes the dependency so lint and tests report independently.
Why this matters (verified on real infra)
I forked this repo and ran
ci.ymlboth ways. With a single redundant# rubocop:disabledirective present (the kind of nit that lands in PRs):needs: lint→ lint fails, 0 / 186 test jobs run (run)So today, any RuboCop offense silently hides the entire test suite — a
contributor learns their formatting is off but nothing about whether their code
works.
On a clean, fully-green pipeline (lint nit fixed on both sides, representative
subset, only this line differing), removing the edge is also faster — tests start
immediately instead of waiting for lint:
needs: lintSafety
lintstill runs on every push/PR and still reports pass/fail — it just no longerblocks or hides the tests. The change is one line.