Exception are not translated to store scope by rikwillems · Pull Request #32953 · magento/magento2

rikwillems · 2021-05-05T19:15:57Z

#31351

Description (*)

Related Pull Requests

magento/inventory#3318

Fixed Issues (if relevant)

Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

magento#31351

m2-assistant · 2021-05-05T19:15:59Z

Hi @rikwillems. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Den4ik · 2021-05-05T21:26:28Z

@magento run all tests

magento-automated-testing · 2021-05-05T21:26:33Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik · 2021-05-06T20:07:59Z

@magento run Functional Tests B2b, WebAPI Tests

magento-automated-testing · 2021-05-06T20:08:04Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

slavvka · 2021-05-07T00:57:56Z

@magento run Semantic Version Checker

magento-automated-testing · 2021-05-07T00:58:00Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik

@rikwillems Thanks for your contribution.
Please look at my comments and update adding of new constructor params based on Backward Compatibility Policy

Den4ik · 2021-05-10T11:51:50Z

app/code/Magento/GraphQl/Controller/GraphQl.php

        HttpResponse $httpResponse = null,
-        ContextFactoryInterface $contextFactory = null
+        ContextFactoryInterface $contextFactory = null,
+        AreaList $areaList


Suggested change

AreaList $areaList

AreaList $areaList = null

Den4ik · 2021-05-10T11:52:31Z

app/code/Magento/GraphQl/Controller/GraphQl.php

        $this->jsonFactory = $jsonFactory ?: ObjectManager::getInstance()->get(JsonFactory::class);
        $this->httpResponse = $httpResponse ?: ObjectManager::getInstance()->get(HttpResponse::class);
        $this->contextFactory = $contextFactory ?: ObjectManager::getInstance()->get(ContextFactoryInterface::class);
+        $this->areaList = $areaList;


Suggested change

$this->areaList = $areaList;

$this->areaList = $areaList ?: ObjectManager::getInstance()->get(AreaList::class);

Please see the updated PR.

Den4ik · 2021-05-10T20:08:17Z

@magento run all tests

magento-automated-testing · 2021-05-10T20:08:22Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik

@rikwillems Thanks for the update. Please see another small request below

Den4ik · 2021-05-10T20:10:05Z

app/code/Magento/GraphQl/Controller/GraphQl.php

        $this->jsonFactory = $jsonFactory ?: ObjectManager::getInstance()->get(JsonFactory::class);
        $this->httpResponse = $httpResponse ?: ObjectManager::getInstance()->get(HttpResponse::class);
        $this->contextFactory = $contextFactory ?: ObjectManager::getInstance()->get(ContextFactoryInterface::class);
+        $this->areaList = $areaList ?: ObjectManager::getInstance()->get(AreaList::class);;


Please remove double semicolon at the end.

Oeps... this is removed now.

cpartica · 2021-12-06T20:35:41Z

app/code/Magento/GraphQl/Controller/GraphQl.php

     * @param ContextFactoryInterface $contextFactory
     * @param LogData $logDataHelper
     * @param LoggerPool $loggerPool
+     * @param AreaList $areaList


@shikhamis11 can you add really quick the " | null" here to be consistent with the constructor?

shikhamis11 · 2021-12-07T05:13:35Z

@magento run all tests

magento-automated-testing · 2021-12-07T05:13:46Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

shikhamis11 · 2021-12-07T05:15:46Z

@magento run all tests

magento-automated-testing · 2021-12-07T05:15:53Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

shikhamis11 · 2021-12-07T12:07:17Z

@magento run Functional Tests B2B, Functional Tests CE

magento-automated-testing · 2021-12-07T12:07:25Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik · 2021-12-08T09:51:55Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-12-08T09:52:01Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Alfa · 2021-12-17T12:40:04Z

✔️ QA Passed

Preconditions:

Have a Magento latest installed with sample data.
Make sure to setup the other language like French and working successfully.

Manual testing scenario:

Login to admin and navigate to Store>configuration>Locale options> Set the language to French(France)
Clear the cache and check in the front end that french language is successfully applied.
Get a customer token from GraphQL query and create a new cart of the customer.
GraphQL request to add new product to the cart (Utilise the wrong SKU to query the request, so that we should see the exception message in the response).

Before: ✖️ The GraphQL response was returning the error message with the English language.

After: ✔️ The GraphQL response is returning the error message with the set French language exactly.

Since it is a GraphQL fix and had the auto-test covered, no additional regression is required on this!

engcom-Alfa · 2021-12-24T10:56:57Z

There is a internal PR ticket raised on this same issue and that is being processed.
So, since this Pr ticket will become duplicate, closing this PR. In case of any changes, we will come back to this same ticket!
Thanks for everybody's collaboration and contribution on this!

hostep · 2022-02-04T08:33:51Z

Hi @engcom-Alfa or @cpartica: is there any news around this?

It's kind of annoying that this public issue got closed and replaced by a private issue that the community can not see into, it would be nice if you stopped doing this in the future, thanks!

cpartica · 2022-02-08T16:56:00Z

The effect is because of the process we have.
This PR will automatically be merged when 2.4.4 is released and merged back into 2.4-develop
We kept your contribution part of the actual fix.
If it works for you I can keep this open until the 2.4.4 event happens and you get in merged status with no action

Please don't update the branch or add any new commits or it will not automerge

m2-assistant · 2022-02-08T16:56:07Z

Hi @rikwillems. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Exception are not translated to store scope

1b4a3bc

magento#31351

m2-community-project bot added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels May 5, 2021

magento-engcom-team added Component: GraphQL GraphQL Release Line: 2.4 labels May 5, 2021

m2-community-project bot added the Progress: pending review label May 5, 2021

Den4ik self-assigned this May 5, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels May 5, 2021

Den4ik requested changes May 10, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels May 10, 2021

Update per Backward Compatibility Policy

f096a71

m2-community-project bot added Progress: review and removed Progress: needs update labels May 10, 2021

Den4ik requested changes May 10, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels May 10, 2021

Fix double semicolon

f05bec2

m2-community-project bot added Progress: review and removed Progress: needs update labels May 10, 2021

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Nov 5, 2021

cpartica approved these changes Nov 5, 2021

View reviewed changes

magento-engcom-team added Component: GraphQL GraphQL and removed Component: GraphQL GraphQL labels Nov 5, 2021

m2-community-project bot added Progress: ready for testing Progress: testing in progress Progress: accept and removed Progress: accept Progress: ready for testing Progress: testing in progress labels Nov 5, 2021

magento-engcom-team added Component: GraphQL GraphQL and removed Component: GraphQL GraphQL labels Nov 5, 2021

cpartica reviewed Dec 6, 2021

View reviewed changes

Updated constructor comment

c7ed1e5

Merge branch '2.4-develop' into 31351-translations-graphql

4635cf1

cpartica approved these changes Dec 8, 2021

View reviewed changes

	$this->areaList = $areaList;
	$this->areaList = $areaList ?: ObjectManager::getInstance()->get(AreaList::class);

Conversation

rikwillems commented May 5, 2021 • edited by shikhamis11 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented May 5, 2021

Uh oh!

Den4ik commented May 5, 2021

Uh oh!

magento-automated-testing bot commented May 5, 2021

Uh oh!

Den4ik commented May 6, 2021

Uh oh!

magento-automated-testing bot commented May 6, 2021

Uh oh!

slavvka commented May 7, 2021

Uh oh!

magento-automated-testing bot commented May 7, 2021

Uh oh!

Den4ik left a comment

Choose a reason for hiding this comment

Uh oh!

Den4ik May 10, 2021

Choose a reason for hiding this comment

Uh oh!

Den4ik May 10, 2021

Choose a reason for hiding this comment

Uh oh!

rikwillems May 10, 2021

Choose a reason for hiding this comment

Uh oh!

Den4ik commented May 10, 2021

Uh oh!

magento-automated-testing bot commented May 10, 2021

Uh oh!

Den4ik left a comment

Choose a reason for hiding this comment

Uh oh!

Den4ik May 10, 2021

Choose a reason for hiding this comment

Uh oh!

rikwillems May 10, 2021

Choose a reason for hiding this comment

Uh oh!

cpartica Dec 6, 2021

Choose a reason for hiding this comment

Uh oh!

shikhamis11 commented Dec 7, 2021

Uh oh!

magento-automated-testing bot commented Dec 7, 2021

Uh oh!

shikhamis11 commented Dec 7, 2021

Uh oh!

magento-automated-testing bot commented Dec 7, 2021

Uh oh!

shikhamis11 commented Dec 7, 2021

Uh oh!

magento-automated-testing bot commented Dec 7, 2021

Uh oh!

Den4ik commented Dec 8, 2021

Uh oh!

magento-automated-testing bot commented Dec 8, 2021

Uh oh!

engcom-Alfa commented Dec 17, 2021

Uh oh!

engcom-Alfa commented Dec 24, 2021

Uh oh!

hostep commented Feb 4, 2022

Uh oh!

cpartica commented Feb 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m2-assistant bot commented Feb 8, 2022

Uh oh!

Reviewers

rikwillems commented May 5, 2021 •

edited by shikhamis11

Loading

cpartica commented Feb 8, 2022 •

edited

Loading