Attempt to fix flaky graphql OrderStatusChangeDateTest.#40618
Open
hostep wants to merge 1 commit intomagento:2.4-developfrom
Open
Attempt to fix flaky graphql OrderStatusChangeDateTest.#40618hostep wants to merge 1 commit intomagento:2.4-developfrom
hostep wants to merge 1 commit intomagento:2.4-developfrom
Conversation
|
Hi @hostep. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
Author
|
@magento run all tests |
Contributor
Author
|
Seems like it didn't fail on the first run, so I'd say that's a good sign this PR didn't cause a new problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
While working on another PR, noticed a failure in the WebAPI Tests suite: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40612/0094f73f811ad6da1dd84b165c063b6c/WebApi/console-error-logs.html
The assumption is that the Order object has an
updatedAttimestamp in memory which differs from the database, as that timestamp is probably generated by MySQL itself and not in PHP.When later asserting its value, the timestamp comes from the in memory object and not from the database, which can lead to millisecond differences and if the test is ran very close to the end of second, then maybe this flakyness can be explained.
I'm trying to fix it by loading the order from the database before fetching the
updatedAttimestamp. Which should hopefully fix this problem. Let's see if this change keeps the test running smoothly🤞Related Pull Requests
N/A
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
Questions or comments
I didn't ran this test locally, let's see how it runs in this PR to see if it keeps working as expected.
Contribution checklist (*)