Trim deployment version in Version\\Storage\\File::load()#40621
Open
Genaker wants to merge 3 commits intomagento:2.4-developfrom
Open
Trim deployment version in Version\\Storage\\File::load()#40621Genaker wants to merge 3 commits intomagento:2.4-developfrom
Genaker wants to merge 3 commits intomagento:2.4-developfrom
Conversation
Trailing newlines in pub/static/deployed_version.txt (e.g. from scripts or editors) were included in the version segment, breaking static URLs and JSON that embeds them (e.g. body data-mage-init loader icon). Refs magento#40620
|
Hi @Genaker. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pub/static/deployed_version.txtis read verbatim inVersion\Storage\File::load(). A trailing newline (common when the file is written with a shell redirect or some editors) becomes part of the deployment version string and breaks static view URLs (/static/version…/…), including JSON that embeds those URLs (e.g.bodydata-mage-initfor the loader icon).Manual testing scenarios
deployed_version.txtcontains only digits + trailing\n→ static URLs andJSON.parseondata-mage-initsucceed.deployed_version.txt/ file unreadable → unchanged (false).Fixes #40620