Fix #39376: correct LoginAsCustomer admin ID key and ScopeResolver phpdoc#40628
Fix #39376: correct LoginAsCustomer admin ID key and ScopeResolver phpdoc#40628pratik268 wants to merge 3 commits intomagento:2.4-developfrom
Conversation
|
Hi @pratik268. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
|
@magento run Unit Tests, Static Tests, Semantic Version Checker |
|
README update is not applicable for this PR because the changes are limited to core PHPDoc/session-key handling and unit tests; no module README predefined sections are impacted. |
|
Pushed follow-up commit addressing CI failures:
@magento run Unit Tests, Static Tests, Semantic Version Checker |
|
@magento run Unit Tests, Static Tests, Semantic Version Checker |
Description (*)
This PR addresses
magento/magento2#39376by fixing two developer-experience issues in core code:Magento\Framework\App\ScopeResolver::$objectManagertoObjectManagerInterface.getLoggedAsCustomerAdminId()firstgetLoggedAsCustomerAdmindId()Also added unit tests for the getter and setter behavior.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
GetLoggedAsCustomerAdminId::execute()returns value from corrected key when present.SetLoggedAsCustomerAdminId::execute()writes both corrected and legacy keys.Questions or comments
Unable to run Magento test suite in this environment because PHP runtime is unavailable in the execution container.
Contribution checklist (*)