Fix: cached rates returned after saving new rates#40648
Open
adamzero1 wants to merge 2 commits intomagento:2.4-developfrom
Open
Fix: cached rates returned after saving new rates#40648adamzero1 wants to merge 2 commits intomagento:2.4-developfrom
adamzero1 wants to merge 2 commits intomagento:2.4-developfrom
Conversation
|
Hi @adamzero1. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
Author
|
@magento run all tests |
Contributor
Author
|
@magento run Static Tests |
Contributor
Author
|
@magento run all tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
When saving new rates, or updating existing ones previously retrieved rates are returned.
This affects integration testing.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Test1#[ DataFixture(\Magento\Quote\Test\Fixture\GuestCart::class, as: 'cart'), ] public function testSomething() { $this->assertTrue(true); }Test2#[ DataFixture(\Magento\Directory\Test\Fixture\CurrencyRate, ['USD' => ['GBP' => '1.0'], 'GBP' => ['USD' => '1.0']]), DataFixture(GuestCartFixture::class, ['reserved_order_id' => 'test_quote'], as: 'cart'), DataFixture(SetGuestEmailFixture::class, ['cart_id' => '$cart.id$']), DataFixture(AddProductToCartFixture::class, ['cart_id' => '$cart.id$', 'product_id' => '$product.id$']), DataFixture(SetBillingAddressFixture::class, [ 'cart_id' => '$cart.id$', 'address' => [ 'prefix' => 'Mr', 'company' => 'Test Company', ] ]), DataFixture(SetShippingAddressFixture::class, [ 'cart_id' => '$cart.id$', 'address' => [ 'prefix' => 'Miss', 'company' => 'Test Company2', ] ]), DataFixture(SetDeliveryMethodFixture::class, ['cart_id' => '$cart.id$']), ] public function testSomething() { $this->assertTrue(true); }Run both, this will produce an error
Run either on their own, it will be fine.
Questions or comments
I was going to make the fixture reset the state after saving rates, but this didn't seem like the correct location.
Contribution checklist (*)