Skip to content

Fix: cached rates returned after saving new rates#40648

Open
adamzero1 wants to merge 2 commits intomagento:2.4-developfrom
adamzero1:currency_rate_cache
Open

Fix: cached rates returned after saving new rates#40648
adamzero1 wants to merge 2 commits intomagento:2.4-developfrom
adamzero1:currency_rate_cache

Conversation

@adamzero1
Copy link
Copy Markdown
Contributor

Description (*)

When saving new rates, or updating existing ones previously retrieved rates are returned.
This affects integration testing.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. create an integration / api testsuite
  2. add two tests
    Test1
#[
        DataFixture(\Magento\Quote\Test\Fixture\GuestCart::class, as: 'cart'),
    ]
    public function testSomething()
    {
        $this->assertTrue(true);
    }

Test2

#[
        DataFixture(\Magento\Directory\Test\Fixture\CurrencyRate, ['USD' => ['GBP' => '1.0'], 'GBP' => ['USD' => '1.0']]),
        DataFixture(GuestCartFixture::class, ['reserved_order_id' => 'test_quote'], as: 'cart'),
        DataFixture(SetGuestEmailFixture::class, ['cart_id' => '$cart.id$']),
        DataFixture(AddProductToCartFixture::class, ['cart_id' => '$cart.id$', 'product_id' => '$product.id$']),
        DataFixture(SetBillingAddressFixture::class, [
            'cart_id' => '$cart.id$',
            'address' => [
                'prefix' => 'Mr',
                'company' => 'Test Company',
            ]
        ]),
        DataFixture(SetShippingAddressFixture::class, [
            'cart_id' => '$cart.id$',
            'address' => [
                'prefix' => 'Miss',
                'company' => 'Test Company2',
            ]
        ]),
        DataFixture(SetDeliveryMethodFixture::class, ['cart_id' => '$cart.id$']),
    ]
    public function testSomething()
    {
        $this->assertTrue(true);
    }

Run both, this will produce an error
Run either on their own, it will be fine.

Questions or comments

I was going to make the fixture reset the state after saving rates, but this didn't seem like the correct location.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link
Copy Markdown

m2-assistant bot commented Apr 7, 2026

Hi @adamzero1. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@adamzero1
Copy link
Copy Markdown
Contributor Author

@magento run all tests

@adamzero1
Copy link
Copy Markdown
Contributor Author

@magento run Static Tests

@adamzero1
Copy link
Copy Markdown
Contributor Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant