Skip to content

config: generate keysym definitions - #1097

Merged
mahkoh merged 5 commits into
masterfrom
jorth/kbvm-update-4
Jul 15, 2026
Merged

config: generate keysym definitions#1097
mahkoh merged 5 commits into
masterfrom
jorth/kbvm-update-4

Conversation

@mahkoh

@mahkoh mahkoh commented Jul 15, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings July 15, 2026 16:22
@mahkoh
mahkoh force-pushed the jorth/kbvm-update-4 branch from 911041c to 7e2cf03 Compare July 15, 2026 16:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves the jay-config keysym constant definitions to a generated source file produced by the codegen crate, reducing the amount of hand-maintained keysym data and aligning the set of “canonical” keysyms with kbvm.

Changes:

  • Add a codegen step that generates jay-config/src/keyboard/syms/generated.rs from kbvm::Keysym::all().
  • Update jay-config to re-export the generated keysyms and keep a smaller set of manual aliases not present in kbvm’s list.
  • Bump kbvm to 0.1.7 across the workspace and update the lockfile accordingly.

Reviewed changes

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
toml-config/Cargo.toml Bumps kbvm dependency version to match the workspace update.
jay-config/src/keyboard/syms.rs Switches keysym constants to generated module re-exports, retaining select manual aliases.
codegen/src/main.rs Registers and runs the new keysym generator.
codegen/src/keysyms.rs Implements keysym constant generation using kbvm::Keysym::all().
codegen/Cargo.toml Adds kbvm dependency needed by the new generator.
Cargo.toml Bumps workspace kbvm dependency to 0.1.7.
Cargo.lock Updates resolved dependency graph for the kbvm bump and related transitive updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mahkoh
mahkoh merged commit fca9da9 into master Jul 15, 2026
13 checks passed
@mahkoh
mahkoh deleted the jorth/kbvm-update-4 branch July 15, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants