config: generate keysym definitions - #1097
Merged
Merged
Conversation
mahkoh
force-pushed
the
jorth/kbvm-update-4
branch
from
July 15, 2026 16:24
911041c to
7e2cf03
Compare
There was a problem hiding this comment.
Pull request overview
This PR moves the jay-config keysym constant definitions to a generated source file produced by the codegen crate, reducing the amount of hand-maintained keysym data and aligning the set of “canonical” keysyms with kbvm.
Changes:
- Add a
codegenstep that generatesjay-config/src/keyboard/syms/generated.rsfromkbvm::Keysym::all(). - Update
jay-configto re-export the generated keysyms and keep a smaller set of manual aliases not present inkbvm’s list. - Bump
kbvmto0.1.7across the workspace and update the lockfile accordingly.
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| toml-config/Cargo.toml | Bumps kbvm dependency version to match the workspace update. |
| jay-config/src/keyboard/syms.rs | Switches keysym constants to generated module re-exports, retaining select manual aliases. |
| codegen/src/main.rs | Registers and runs the new keysym generator. |
| codegen/src/keysyms.rs | Implements keysym constant generation using kbvm::Keysym::all(). |
| codegen/Cargo.toml | Adds kbvm dependency needed by the new generator. |
| Cargo.toml | Bumps workspace kbvm dependency to 0.1.7. |
| Cargo.lock | Updates resolved dependency graph for the kbvm bump and related transitive updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.